Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scopes - Add optic_DMS_weathered_Kir_F ACE3 values #10488

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

Laid3acK
Copy link
Contributor

@Laid3acK Laid3acK commented Nov 8, 2024

When merged this pull request will:

  • Add ACE3 values to the optic_DMS_weathered_Kir_F, same that all other DMS scopes, to have a zeroed distance at 100m, not vanilla 200m which is not the best choice for a subsonic ammunition.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror PabstMirror added this to the 3.18.2 milestone Nov 8, 2024
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Nov 8, 2024
@PabstMirror
Copy link
Contributor

just for ref these are the
Burris XTR II (ASP-1 Kir) and Burris XTR II (Old)
which look identical, but have different discreteDistance in vanilla for some reason

@Laid3acK
Copy link
Contributor Author

Laid3acK commented Nov 9, 2024

We have also the possibility to keep the specific Burris XTR II (ASP-1 Kir) vanilla discreteDistance and add only ACE3 windage.
Players will have the choice between a full ACE3 Burris XTR II (Old) and a mixed "vanilla - ACE3" Burris XTR II (ASP-1 Kir).
I will make a PR with this second possibility, you will choose at your convenience the best.

@LinkIsGrim LinkIsGrim merged commit 9204e8d into acemod:master Nov 15, 2024
3 checks passed
@Laid3acK Laid3acK deleted the update_optic_dms_weathered_kir_f branch November 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants