Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overheating - Improve getWeaponData by saving weapon config to variable #10508

Merged

Conversation

DartRuffian
Copy link
Contributor

When merged this pull request will:

  • Save the config path to the given weapon to a variable, and using that instead
    • There are not functionality changes in this PR.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@DartRuffian
Copy link
Contributor Author

DartRuffian commented Nov 14, 2024

This testing obviously isn't realistic, but I commented out all of the cache related lines (i.e. the get / set) and did some basic tests just to see what the difference would be like.

Current master ranged from ~260-265 ms for 10k cycles.
This PR ranged from ~200-204 ms for 10k cycles.

@PabstMirror PabstMirror added this to the 3.18.2 milestone Nov 14, 2024
@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Nov 14, 2024
@johnb432 johnb432 merged commit f8e0900 into acemod:master Nov 14, 2024
3 checks passed
@DartRuffian DartRuffian deleted the overheating/optimize-config-lookup branch November 14, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants