Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expeditionary Forces Compatibility #10524

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Expeditionary Forces Compatibility #10524

merged 4 commits into from
Dec 13, 2024

Conversation

PabstMirror
Copy link
Contributor

No description provided.

@PabstMirror PabstMirror added the kind/feature Release Notes: **ADDED:** label Nov 25, 2024
@PabstMirror PabstMirror added this to the 3.18.2 milestone Nov 25, 2024
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mrschick mrschick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this also add realistic names? i.e: for the new M-ATV variants.

@Apricot-ale
Copy link
Contributor

Apricot-ale commented Nov 27, 2024

Thanks for your work.

I think AH-99J (RAH-66 with external stub wings) should have a real name like M-ATV (because the base is already a real name), but I don't know what's the best name for it.
Should it be called Heavy Attack or Armed? Or should it just be RAH-66J?

And should the new types of vehicles added this time, AAV-9 (EFV/AAAV), LCC-1 (EDA-R/L-CAT), and Combat Boat (Stridsbåt NY or CB90 NG), have real names?
I personally think it's fine to keep the names as they are, but Combat Boat might be changed. What do you think?

I don't know much about infantry equipment, but I think it's fine as is. NVG (PVS-21?) is also fine as is.

@mrschick
Copy link
Contributor

Or should it just be RAH-66J?

IMO that's the cleanest one.

@Apricot-ale
Copy link
Contributor

Or should it just be RAH-66J?

IMO that's the cleanest one.

Yeah I think too, It's feels like A-10D (A-164 Wipeout)

@PabstMirror
Copy link
Contributor Author

Would there be any overpressure on the 50mm autocannon? I didn't think so but wasn't sure

@Apricot-ale
Copy link
Contributor

Assuming that it's clear that it's an XM913.
This is just my opinion, but I think there is some overpressure.
It felt the same as a 57mm naval gun to me.

I think it would be natural if it was about the same or bit powerful as the BMP3/BMD4 2A70 100mm low-pressure cannon.

@LinkIsGrim LinkIsGrim merged commit 80d6fd3 into master Dec 13, 2024
3 checks passed
@LinkIsGrim LinkIsGrim deleted the efCompat branch December 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants