ASDG- Fail gracefully if attachments not compatible #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we be adding exceptions for addons in the core code? Shouldn't this be handled more gracefully with them? I don't want to get into the habit of having to hard-code 50 exceptions into our core code all over the place like this. I don't like it at all. We should probably request ASDG to handle this aspect of it for us, no? |
|
ASDG is fairly unique as a mods goes, we really only have 1 rail compatibility mod to worry about. I don't think ASDG can't really do anything about this. They have to change PointerSlot/compatibleItems on vanilla weapons to use their system. |
PabstMirror
added a commit
that referenced
this pull request
Jun 5, 2015
ASDG- Fail gracefully if attachments not compatible
|
👍 |
|
When ASDG JR is in CBA, this will have to be changed afaik (unless the class will stay the same). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce: run @asdg without the ace_asdg_comp - hit ctrl-L, laser pointer is gone.
ASDG messes with
PointerSlotand compatible items.If a user has ASDG installed without our compatibilty patch, then it seems like none of our ACE_x attachements will work on weapons.
With laser pointers, on switch we delete the current and then add the new laser. If that new laser isn't compatible then it won't get added and the user will have nothing.
This dumps several error messages in the RPT and if the
ACE_nextModeClassdoesn't get added then it reverts back to the current so nothing is lost.