Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IED pressure plates #1248

Merged
merged 3 commits into from
May 16, 2015
Merged

IED pressure plates #1248

merged 3 commits into from
May 16, 2015

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented May 16, 2015

#1191

Thanks to @legman for his config!

@nicolasbadano nicolasbadano added the kind/enhancement Release Notes: **IMPROVED:** label May 16, 2015
@nicolasbadano nicolasbadano added this to the 3.0.1 milestone May 16, 2015
@nicolasbadano
Copy link
Contributor

👍 Looks perfect to me

@nicolasbadano
Copy link
Contributor

@jonpas, @legman: we need legman added to authors.txt, with a valid email address before merging this.

Thank you very much to both of you

@jonpas
Copy link
Member Author

jonpas commented May 16, 2015

@legman if you give me your email address I can add you.

@legman
Copy link
Contributor

legman commented May 16, 2015

hey lads - my email is juicemelon@msn.com

@jonpas
Copy link
Member Author

jonpas commented May 16, 2015

Added, thanks!

nicolasbadano added a commit that referenced this pull request May 16, 2015
@nicolasbadano nicolasbadano merged commit dd6f503 into acemod:master May 16, 2015
@nicolasbadano
Copy link
Contributor

Merged, thank you both again.

@jonpas
Copy link
Member Author

jonpas commented May 16, 2015

Yay! ✋ @legman

@jonpas jonpas deleted the iedPressurePlates branch May 16, 2015 17:17
@legman
Copy link
Contributor

legman commented May 18, 2015

I am currently making some amends to this change - how should I go about providing you with the changes when I am done?

Things I am changing:

  • Separated out several IED ammo types which stops every vanilla IED being pressure plated. (This caused a bug where any IED armed, even with a cellphone would be triggered when stepped on)
  • Improved class inheritance for new IEDs
  • Making the urban IEDs have less BOOM than the 'Artillery Shell' IEDs but support fragmentation and act more like a AP Mine
  • Made the triggerSound louder

@legman
Copy link
Contributor

legman commented May 18, 2015

Also I noticed 'ACE_explodeOnDefuse' is either on or off, it would be nice if this had some random chance to it such as an additional param 'ACE_explodeOnDefuseChance' which ranges from 0.0 - 1.0?

Let me know what you think of this idea as it could easily be implemented into fnc_defuseExplosive!

@jonpas
Copy link
Member Author

jonpas commented May 18, 2015

Best is if you simply pull request your changes.

@legman
Copy link
Contributor

legman commented May 18, 2015

ok awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants