Cut Parachute/Reserve parachute #1307

jokoho48 · 2015-05-19T12:17:43Z

this is a small module that bring the Reserve parachute back out of ACE2(One of the Importent Features out of there I think)
Hop every thing is Correct, if not tell me i try to fix it

Change to Macros

KoffeinFlummi · 2015-05-19T12:19:52Z

addons/parachute/XEH_respawn.sqf

+ * Public: No
+ */
+#include "script_component.hpp"
+SETVAR(_unit,chuteIsCuted,false);


"cut", not "cuted".

nicolasbadano · 2015-05-19T12:32:26Z

addons/parachute/functions/fnc_cutParachute.sqf

+_vehicle = vehicle _unit;
+_unit action ["GetOut", vehicle _unit];
+deleteVehicle _vehicle;
+_unit addBackpack "B_Parachute";


There are more than one type of parachutes in the game through mods (ACE adds the ACE_NonSteerableParachute variant besides B_Parachute).

The parachute added should be of the same class of that the unit originally had, which we probably need to store.

nicolasbadano · 2015-05-19T12:34:26Z

Is it possible to add the backup parachute as soon as the main one is opened? Currently you loose the backpack when you open the first one, but then get it back when you cut it, which is less than ideal. The playerInventoryChanged event could be used to detect that.

jokoho48 · 2015-05-19T13:03:42Z

ok i will try my best
best not Merge this i start working on this

thojkooi · 2015-05-19T14:14:07Z

addons/parachute/stringtable.xml

+        <Key ID="STR_ACE_Parachute_CutParachute">
+            <English>Cut Parachute</English>
+            <German>Fallschirm abschneiden</German>
+		</Key>


Fix Adding anytime B_Parachute Fix Reserve Parachute Added if Normal Parachute Open

jokoho48 · 2015-05-19T16:18:18Z

so hop this is now done

jaynus · 2015-05-19T16:23:40Z

addons/parachute/functions/fnc_storeParachute.sqf

+if ((vehicle _unit) isKindOf "ParachuteBase" || (backpack _unit == "")) then {
+    _unit addbackpack (_unit getVariable[QGVAR(backpackClass),""]);
+} else {
+    if (getText(configfile >> "CfgVehicles" >> _backpack >> "ParachuteClass") in ["NonSteerable_Parachute_F","B_Parachute_02_F","O_Parachute_02_F","I_Parachute_02_F","Steerable_Parachute_F"]) then {


Does anyone have a better idea on a way to make this dynamic? Currently we are hard coding to only these Parachutes. Could you check inheritence instead, so this would be expanded with modded parachutes?

the only way to do this is to remove this complet and did it for every backpack but this is not that what i want to do

we could add a Config entry for Mod maker to say this is a Parachute and there we can add the a kindof what is the Reserve Parachute because normaly it was not the same normaly its a NonSteerable

thojkooi · 2015-05-19T19:17:39Z

addons/parachute/functions/fnc_checkCutParachute.sqf

+ * Public: No
+ */
+
+_unit = _this select 0;


Missing private

jokoho48 · 2015-05-20T19:57:30Z

I need here to do something more? or is everything fine

nicolasbadano · 2015-05-20T22:06:43Z

addons/parachute/functions/fnc_storeParachute.sqf

+_unit = _this select 0;
+_backpack = (_this select 1) select 6 ;
+if ((vehicle _unit) isKindOf "ParachuteBase" || (backpack _unit == "")) then {
+    _unit addBackpack (_unit getVariable[QGVAR(backpackClass),"ACE_NonSteerableParachute"]);


@jokoho48, the condition above is incomplete. This would add a non steerable parachute every time e.g. you reload your weapon without a packpack.

(playerInventoryChanged fires every time the inventory of the unit changes for whatever reason, including loading magazines on the gun, dropping things from the ground, etc.)

add New Config Parameter has Reserve Parachute

alganthe · 2015-05-23T20:50:28Z

Did some tests with it, couldn't break it !
You get a good point 😄
The feature is really interesting, and works very well good job.

thojkooi · 2015-05-23T20:53:59Z

addons/parachute/functions/fnc_storeParachute.sqf

+  private ["_unit","_backpack"];
+  _unit = _this select 0;
+  _backpack = (_this select 1) select 6 ;
+  if ((vehicle _unit) isKindOf "ParachuteBase" && backpack player == "" && !(_unit getVariable [QGVAR(chuteIsCut),false]) && (_unit getvariable [QGVAR(hasReserve),false])) then {


Use ACE_player instead of player.

i think _unit is better

jokoho48 · 2015-05-23T21:51:33Z

@alganthe Thanks

Conflicts: addons/parachute/functions/fnc_storeParachute.sqf

jokoho48 · 2015-06-30T23:18:53Z

i think its is ready to go

jonpas · 2015-07-01T00:26:56Z

@jokoho48 Fix merge conflicts (merge latest master into your branch, fix conflicts, commit).

…aster Conflicts: AUTHORS.txt addons/parachute/CfgVehicles.hpp

Use CString Macro

jokoho48 · 2015-07-01T01:05:52Z

ok i think its now Done and it killed me Twice

Cut Parachute/Reserve parachute

jokoho48 added 5 commits May 19, 2015 13:45

Add Cut Parachute

f06f38a

TAAAABBBBSSSSSS

75be6a1

Prevent Respawn bug

e403101

Change to Macros

Update AUTHORS.txt

6a5e126

Fail J in AUTHORS.txt

44bc4ff

KoffeinFlummi reviewed May 19, 2015
View reviewed changes

chuteIsCuted -> chuteIsCut

7a012a5

nicolasbadano reviewed May 19, 2015
View reviewed changes

thojkooi added the status/WIP label May 19, 2015

thojkooi reviewed May 19, 2015
View reviewed changes

Update to ACE Standarts

48f4481

Fix Adding anytime B_Parachute Fix Reserve Parachute Added if Normal Parachute Open

jaynus reviewed May 19, 2015
View reviewed changes

Add Posible to use Mod Parachutes

4db9989

thojkooi reviewed May 19, 2015
View reviewed changes

addons/parachute/functions/fnc_checkCutParachute.sqf

* Public: No

*/

_unit = _this select 0;

Copy link

Contributor

thojkooi May 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing private

Fixing Privates

bc535c9

reset Form SETVAR to setVariable

8c69ff4

nicolasbadano reviewed May 20, 2015
View reviewed changes

Fix Reload Bug

41c6ea8

jaynus added the status/needs-testing label May 21, 2015

jaynus added this to the 3.2.0 milestone May 21, 2015

jokoho48 added 3 commits May 21, 2015 14:03

Enhance some scripts

ccd3fb8

add New Config Parameter has Reserve Parachute

fix adding a New Parachute if one already given

f8003fd

Fix gettings anytime a new Parachute

9a212f0

thojkooi reviewed May 23, 2015
View reviewed changes

player -> ACE_player

c0afd9f

jokoho48 added 3 commits May 23, 2015 23:58

ACE_player -> _unit

1f5f5a2

Merge branch 'master' of https://github.com/jokoho48/ACE3

b007217

Conflicts: addons/parachute/functions/fnc_storeParachute.sqf

add Compatibilty to mods where the Animation are not "para_pilot"

e072245

jokoho48 added 3 commits July 1, 2015 02:49

Merge branch 'master' of https://github.com/acemod/ACE3 into acemod-m…

a74bc3a

…aster Conflicts: AUTHORS.txt addons/parachute/CfgVehicles.hpp

Merge branch 'acemod-master'

737753f

Fix Merge Problems

30111b4

Use CString Macro

thojkooi self-assigned this Jul 19, 2015

ViperMaul added the target/next-milestone? label Jul 19, 2015

thojkooi removed target/next-milestone? status/WIP labels Jul 25, 2015

thojkooi added a commit that referenced this pull request Jul 25, 2015

Merge pull request #1307 from jokoho48/master

9d7374c

Cut Parachute/Reserve parachute

thojkooi merged commit 9d7374c into acemod:master Jul 25, 2015

jonpas added kind/feature Release Notes: **ADDED:** and removed status/needs-testing labels Aug 27, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cut Parachute/Reserve parachute #1307

Cut Parachute/Reserve parachute #1307

jokoho48 commented May 19, 2015

KoffeinFlummi May 19, 2015

nicolasbadano May 19, 2015

nicolasbadano commented May 19, 2015

jokoho48 commented May 19, 2015

thojkooi May 19, 2015

jokoho48 commented May 19, 2015

jaynus May 19, 2015

jokoho48 May 19, 2015

jokoho48 May 19, 2015

thojkooi May 19, 2015

jokoho48 commented May 20, 2015

nicolasbadano May 20, 2015

alganthe commented May 23, 2015

thojkooi May 23, 2015

jokoho48 May 23, 2015

jokoho48 commented May 23, 2015

jokoho48 commented Jun 30, 2015

jonpas commented Jul 1, 2015

jokoho48 commented Jul 1, 2015

Cut Parachute/Reserve parachute #1307

Cut Parachute/Reserve parachute #1307

Conversation

jokoho48 commented May 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolasbadano commented May 19, 2015

jokoho48 commented May 19, 2015

Choose a reason for hiding this comment

jokoho48 commented May 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jokoho48 commented May 20, 2015

Choose a reason for hiding this comment

alganthe commented May 23, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jokoho48 commented May 23, 2015

jokoho48 commented Jun 30, 2015

jonpas commented Jul 1, 2015

jokoho48 commented Jul 1, 2015