Fix ace_settings

[PabstMirror]

Problem with #1214
this should also solve issue #1273

Clients don't localize and they don't load settings from profile.

I think the problem is we never raise the ServerSettingsReceived on clients and GVAR(SettingsInitialized) never changes to true, so that PFEH at bottom of postInit runs forever.

Server language english
Client screenshot in spanish:

[nicolasbadano]

I think the problem is we never raise the ServerSettingsReceived

That's because this line is wrong:

https://github.com/acemod/ACE3/blob/master/addons/common/XEH_preInit.sqf#L313

should be a globalEvent

[PabstMirror]

What about JIPs or if the server triggers the event before clients load.

[nicolasbadano]

What about JIPs or if the server triggers the event before clients load.

That's a good point. TBH the localEvent thing is a typo, but your implementation covers those topics better. Let me think it a minute

[nicolasbadano]

Right, I like you solution (which is actually THE solution). Hold on a minute more while I fix my bloody mess

[nicolasbadano]

@PabstMirror, please check that last commit in case I'm derping again. But I think I now see it: the "ServerSettingsReceived" event was redundant, as it's much better to check isNil QGVAR(settings) as you proposed, which is JIP compatible.

[thojkooi]

Do we want to print this to the rtp? What if the settings arrive late? Then we have spammed the rtp with quite a few messages. There is no need to print this multiple times I think.

[nicolasbadano]

Well, I noticed that, but I decided leaving that spam on the first version should be good, to be able to easily check how long the settings are delaying. I propose to remove it on the next update.