Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CheckPBO Kick #1635

Merged
merged 1 commit into from
Jun 15, 2015
Merged

Fixed CheckPBO Kick #1635

merged 1 commit into from
Jun 15, 2015

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Jun 15, 2015

  • Removed function adminKick as it is now redundant
  • Used close display 46 in combination with errorMessage function
  • Actual error message is what it is until a rewrite of CheckPBOs comes, meaning no displaying of what mods in the error pop-up as that is displayed in chat from a separate script - hence why waitUntil is also needed

@nicolasbadano nicolasbadano added the kind/bug-fix Release Notes: **FIXED:** label Jun 15, 2015
@nicolasbadano nicolasbadano added this to the 3.1.0 milestone Jun 15, 2015
nicolasbadano added a commit that referenced this pull request Jun 15, 2015
@nicolasbadano
Merge pull request #1635 from jonpas/fixCheckPBOkick
fbf9922 
Fixed CheckPBO Kick
@nicolasbadano nicolasbadano merged commit fbf9922 into acemod:release Jun 15, 2015
@nicolasbadano
Copy link
Contributor

Thanks!

@jonpas jonpas deleted the fixCheckPBOkick branch June 15, 2015 18:48
@thojkooi thojkooi mentioned this pull request Jun 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jonpas @nicolasbadano