Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual attach object #1739

Merged
merged 5 commits into from
Jul 25, 2015
Merged

Virtual attach object #1739

merged 5 commits into from
Jul 25, 2015

Conversation

PabstMirror
Copy link
Contributor

This is for attach, but the same idea could be applied to explosives which has had issues like
#1234 (Glitching items into the player moves them over the map).

Both systems want to show a virtual object when placing something.

Instead of createVehicle and updating it's pos every frame, this just show the p3d on the hud in the same position and scale as it would be if it were real.

Pros: Zero network traffic, No physX collisions

Cons: Looks bad in 3rd person (it's rendered separately from the main scene, so there is no z-buffer), also no lighting/nvg effects:

2015-06-24_00002

@nicolasbadano
Copy link
Contributor

Great. I love this

@PabstMirror
Copy link
Contributor Author

Video: https://www.youtube.com/watch?v=iVuB8Z6OE7I
2nd half shows how it looks in 3rd person. Like I said, it's bad. I think the size and position of the object are right, but it should be rendered behind the player's head and obscured.

I tend to be "Function Over Form", but I'm not sure how critical of an issue it will be for others. Given all of the issues with real objects, I think it's worth it.

If people are ok with this then I'll try doing the same for explosives.

@nicolasbadano
Copy link
Contributor

Given all of the issues with real objects, I think it's worth it.

I second that. @ViperMaul, @Glowbal, @KoffeinFlummi, I guess this is your call.

If people are ok with this then I'll try doing the same for explosives.

I agree.

@nicolasbadano
Copy link
Contributor

Hey, quick idea. For third person placement, we could offset the origin of the ray 30 cm to the right of the head, so it would be less likely the head obscure the placing position and it's easier to see where you are putting the thing.

@jonpas
Copy link
Member

jonpas commented Jul 1, 2015

I tend to be "Function Over Form", but I'm not sure how critical of an issue it will be for others.

Don't think it will be one at all, usually you put it down in a few seconds after selecting it anyways.

@PabstMirror
Copy link
Contributor Author

@esteldunedain - 30cm was a perfect offset, looks better now that it is not over the head.

untitled2

@nicolasbadano
Copy link
Contributor

Yay! Over the shoulder third person action
El 8/7/2015 5:58 p. m., "PabstMirror" notifications@github.com escribió:

@esteldunedain https://github.com/esteldunedain - 30cm was a perfect
offset, looks better now that it is not over the head.

[image: untitled2]
https://cloud.githubusercontent.com/assets/9376747/8581963/9b0b6ae0-2589-11e5-9fe6-d1902e6f0989.jpg


Reply to this email directly or view it on GitHub
#1739 (comment).

@jonpas jonpas mentioned this pull request Jul 10, 2015
@kymckay
Copy link
Member

kymckay commented Jul 21, 2015

What's the status on this?

Just awaiting dev feedback? I think the benefits are worth the drawbacks.

@PabstMirror PabstMirror added this to the 3.2.0 milestone Jul 25, 2015
PabstMirror added a commit that referenced this pull request Jul 25, 2015
@PabstMirror PabstMirror merged commit 7da2581 into master Jul 25, 2015
@PabstMirror PabstMirror deleted the virtualAttachObject branch July 25, 2015 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** status/discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants