Add Posibility to Change Backblast Values in Magazine Config and Add Caching for Backblast #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokoho48
changed the title
| * None | ||
| */ | ||
|
|
||
| if (missionNameSpace getVariable [(QGVAR(Damage) + _this select 1),(([_this select 1,_this select 5] call DFUNC(cacheOverPressureVales)) select 2)]) then { |
There was a problem hiding this comment.
This should be divided. Because of how SQF works, the second term of the array is evaluated regardless if the value is already cached or not, so performance is wasted nonetheless.
Typically you need to do:
_varName = (QGVAR(Damage) + _this select 1);
if (isNil _varName) then {
...
} else {
...
};
|
Status? |
update code to params command update Comments
|
Need Review and hard testing because i rewrite the caching in complett |
| private ["_var","_varName","_backblastAngle", "_backblastRange", "_backblastDamage"]; | ||
| _varName = format [QGVAR(values%1%2%3), _weapon, _ammo, _magazine]; | ||
| _var = if (isNil _varName) then { | ||
| [_weapon,_magazine] call FUNC(cacheOverPressureVales); |
There was a problem hiding this comment.
cacheOverPressureVales should be cacheOverPressureValues
| // Bake Variable Name and Check if the Variable Exist else call the Cache Function | ||
| _varName = format [QGVAR(values%1%2%3), _weapon, _ammo, _magazine]; | ||
| _var = if (isNil _varName) then { | ||
| ([_weapon, _ammo, _magazine] call FUNC(cacheOverPressureVales)) select 2; |
| _dangerZoneAngle = getNumber (configFile >> "CfgWeapons" >> _weapon >> QGVAR(angle)) / 2; | ||
| _dangerZoneRange = getNumber (configFile >> "CfgWeapons" >> _weapon >> QGVAR(range)); | ||
| _dangerZoneDamage = getNumber (configFile >> "CfgWeapons" >> _weapon >> QGVAR(damage)); | ||
| // Bake Variablen Name and Check if the Variable Exist else call the Cache Function |
There was a problem hiding this comment.
// Bake variable name and check if the variable exists, call the caching function otherwise
fix Input
|
From looking at the code, apart from those minor comment changes, it looks good to me 👍 |
|
ok fixed Done |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1829
and for Performance Improvement