#1871 - Don't do ctrlText(set) on RscControlsGroup

[PabstMirror]

#1871

Doing ctrlText or ctrlSetText on a RscControlsGroup spams the rpt with

control[ACE_ScriptedDisplayControlsGroup]: Unexpected control type [15]

We do both each frame so I believe it is the source of the frame lag when using the vector.

[kymckay]

Is there a reason we're looping through all the controls instead of just getting control 170?

[jonpas]

It seems like it has to be executed on all controls but 170 !=.

[PabstMirror]

I have no clue why it was done that way.
count allControls (uiNamespace getVariable "ACE_dlgVector") is 23, but we really only want to change 16 of them, the rest are dummy arma controls and the control group..

[kymckay]

It seems like it has to be executed on all controls but 170

Another example of why I shouldn't review scripts when tired 😛

I guess it's not such a big deal, but I'd personally be inclined to change the forEach to an array of idcs and do it that way.

Looks good though 👍