Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category optionsmenu #852 #2058

Merged
merged 15 commits into from
Aug 8, 2015
Merged

Add category optionsmenu #852 #2058

merged 15 commits into from
Aug 8, 2015

Conversation

thojkooi
Copy link
Contributor

@thojkooi thojkooi commented Aug 8, 2015

  • Adds a category selection to the options menu, both client and config export variants.
  • Two of the larger modules with settings received categories with this PR. All others still require adding them.
  • All categories are localized for clients.

Adding a new category is done through adding the following attribute to a settings entry:

category = "STR_ACE_Module_Category";

Obviously replace module by whatever module the setting belongs to and add the string to the stringtable entry with necessary translations. No other requirements.

@thojkooi thojkooi added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Aug 8, 2015
@thojkooi thojkooi added this to the 3.3.0 milestone Aug 8, 2015
@jonpas
Copy link
Member

jonpas commented Aug 8, 2015

category = "STR_ACE_Module_Category";

You mean category = "$STR_ACE_Module_Category"; (with a $ sign).

@MikeMatrix
Copy link
Contributor

Uh interesting. Definitely have to take a look at this later.
Something we desperately needed.

@thojkooi
Copy link
Contributor Author

thojkooi commented Aug 8, 2015

No, I don't. Using $ would mean the clients receive the localized string from the server.

@jonpas
Copy link
Member

jonpas commented Aug 8, 2015

Ah I see, my bad!

@thojkooi
Copy link
Contributor Author

thojkooi commented Aug 8, 2015

You made me double check the macro I used though - turns out I did use the wrong one. Fixed now.

@jonpas
Copy link
Member

jonpas commented Aug 8, 2015

Hehe, glad I helped 🍌

@@ -267,5 +267,8 @@
<Czech>Přidá možnost interakce pro otevření dvěří a umistňovat žebříky na budovy. (Poznámka: Použití této možnosti snižuje výkon při otevírání pomocí interakčního menu, zejména ve velkých městech.) </Czech>
<Spanish>Añade las acciones de interacción para la apertura de puertas y montaje de escaleras en los edificios. (Nota: Hay un coste de rendimiento al abrir el menú de interacción, especialmente en las ciudades)</Spanish>
</Key>
<Key ID="STR_ACE_Interact_Menu_Category_InteractionMenu">
<English>Interaction Menu</English>
</Key>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Polish>Menu interakcji</Polish>

PabstMirror and others added 3 commits August 8, 2015 12:36
Conflicts:
	addons/optionsmenu/functions/fnc_serverSettingsMenuUpdateList.sqf
	addons/optionsmenu/functions/fnc_settingsMenuUpdateList.sqf
@SzwedzikPL
Copy link
Contributor

It would be great to see options menu in CBA :)

thojkooi added a commit that referenced this pull request Aug 8, 2015
@thojkooi thojkooi merged commit f02a00a into master Aug 8, 2015
@thojkooi thojkooi deleted the add-category-optionsmenu branch August 8, 2015 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants