Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HR and BP enhancement #2268

Merged
merged 6 commits into from
Aug 29, 2015
Merged

HR and BP enhancement #2268

merged 6 commits into from
Aug 29, 2015

Conversation

gienkov
Copy link
Contributor

@gienkov gienkov commented Aug 26, 2015

  • It will display 0 HR and fail to find BP on limbs that have TQ on.
  • Check for TQ is run only if medic is checking pulse on arms.

@@ -46,9 +46,14 @@ if (_heartRate > 1.0) then {
};
};

if (_selectionName in ["hand_l","hand_r"] && [_unit, _selectionName] call FUNC(hasTourniquetAppliedTo)) then {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add here lazyEelevation that could Improve the Performance
if (_selectionName in ["hand_l","hand_r"] && {[_unit, _selectionName] call FUNC(hasTourniquetAppliedTo)}) then {

@jokoho48 jokoho48 added kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:** status/discussion labels Aug 26, 2015
@jokoho48 jokoho48 assigned jokoho48 and thojkooi and unassigned jokoho48 Aug 26, 2015
@thojkooi
Copy link
Contributor

Doesn't take all limbs into account (leg_l and leg_r)

@gienkov
Copy link
Contributor Author

gienkov commented Aug 26, 2015

You don't check BP/HR on legs that's why check for arms only. You don't even get an option to check BP/HR on legs.

@gienkov gienkov changed the title Pulse enhancement HR and BP enhancement Aug 26, 2015
@gienkov
Copy link
Contributor Author

gienkov commented Aug 26, 2015

Did the same for BP, it will display _You fail to find a blood pressure_ (it's in stringtable).

@thojkooi thojkooi added this to the 3.3.0 milestone Aug 29, 2015
thojkooi added a commit that referenced this pull request Aug 29, 2015
@thojkooi thojkooi merged commit 354e441 into acemod:master Aug 29, 2015
@gienkov gienkov deleted the pulse-enhancement branch September 21, 2015 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:** kind/feature Release Notes: **ADDED:** status/discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants