Ported AGM_Explosives to ace. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked locations where Scheduled Delay Execution will probably need to be used.
…ting anything to config. Will still need further testing once interaction is fully integrated.
Converted startTimer to CBA's perFrameEventHandler.
…ile. To reduce potential pain areas if a rename occurs.
|
Anyone care to give this a look see? Since interaction isn't working yet (from what I could tell). It's not entirely possible to see if it is working in game but I did some function calls and they mostly seemed to be working. |
|
I don't see anything wrong with the code having just skimmed it, everything is event based it seems for the most part. A couple style things I found odd, but nothing big, just the use of capital letters on engine functions, but I don't think we have a standard for that and it's just me being pedantic really. |
|
Tested in game with the calls as well seems to work fine except for interact. Merging in for pending interact finishing. |
MikeMatrix
pushed a commit
to MikeMatrix/ACE3
that referenced
this pull request
Aug 4, 2015
Ongoing code cleanup
SzwedzikPL
pushed a commit
to SzwedzikPL/ACE3
that referenced
this pull request
Jul 31, 2022
Remove null projectiles from iron dome nonTrackingProjectiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked locations where Scheduled Delay Execution will probably need to be used.
*Relies on Interaction and Core to be fully ported before it will function correctly.