Add GAU-8 Enhancement #4497

sargken · 2016-10-01T20:55:50Z

This is the same concept done as here #1976.
Adds in the Enhanced GAU-8 Mod
Credit goes to @AlexusDE and @ZabuzaW

Has been tested in a single player environment.

The following list presents all added/changed features:

changed the calibre to 30mm
increased muzzle velocity to 1030 m/s
increased direct and indirect hit damage
increased bullet spread
added 2 burst modes: “Low” (1.5s, 2100rpm) and “High” (1.5s, 4200rpm)
magazine size of 1174 rounds
changed weapon sound (featuring the typical GAU-8 “fart of death”)
new impact sound
smoke effect while shooting the gun
new impact effects (more smoke, flashing light of explosions)

Further Info on the mod

Forgot to add in my name for the porting of it.

jonpas · 2016-10-01T20:57:17Z

Can you describe what exactly this pull request changes/adds in detail? Maybe a video of the change or something.

sargken · 2016-10-01T21:00:37Z

https://www.youtube.com/watch?v=AD1GlElqo74 - Old video if you need a new video I can make one up.

sargken · 2016-10-01T21:04:50Z

My goal was to recreate the pull request @SzwedzikPL created, but never finished or at least it was never brought into ACE. I contacted the author of the mod and he was on board 100%,

jonpas · 2016-10-01T21:06:09Z

Cool, we'll review it! 👍

Zabuzard · 2016-10-01T21:56:02Z

Essentially it's an ACE-port of the Mighty GAU-8/A Avenger Mod of @AlexusDE and me. @sargken was so nice to adjust it so it fits to the ACE-guidelines. The mod is also at GitHub, it can be found here: ZabuzaW/MightyGau-8Avenger

Here's a list of features:

changed the caliber to 30mm
increased muzzle velocity to 1030 m/s
increased direct and indirect hit damage
increased bullet spread
added 2 burst modes: “Low” (1.5s, 2100rpm) and “High” (1.5s, 4200rpm)
magazine size of 1174 rounds
changed weapon sound (featuring the typical GAU-8 “fart of death”)
new impact sound
smoke effect while shooting the gun
new impact effects (more smoke, flashing light of explosions)
removed tracers, only visible with NVG
the A-164 now carries 240 countermeasure flares

And here's a showcase video:
Youtube#AD1GlElqo74

jonpas · 2016-10-01T21:59:38Z

I am all for it, I think it fits ACE3 as it improves realism of the plane's armament.

jonpas

Apart from those the PR looks good to me. I can't comment on the actual config though.

jonpas · 2016-10-01T22:01:22Z

addons/aircraft/functions/fnc_gau8_muzzleEffect.sqf

+private ["_weapon", "_projectile", "_i", "_no"];
+
+_weapon =  param [1];
+_projectile = param [6];


Should use params.

Could you help me out on this using params how would i make them select the specific elements i need? params ["_weapon", "_projectile"];

_weapon need to be element 1
_projectile needs to be element 6

params ["", "_weapon", "", "", "", "", "_projectile"];

Although in this case it's probably better to do:

private _weapon = _this select 1; private _projectile = _this select 6;

jonpas · 2016-10-01T22:01:42Z

addons/aircraft/functions/fnc_gau8_muzzleEffect.sqf

+ */
+#include "script_component.hpp"
+
+private ["_weapon", "_projectile", "_i", "_no"];


We use inline private _variable = "bla";, please change to that.

How would I make _i private using the method you want.

jonpas · 2016-10-01T22:01:48Z

addons/aircraft/functions/fnc_gau8_muzzleEffect.sqf

+ *
+ * Return value:
+ * None
+ *


Missing example.

Already fixed

jonpas · 2016-10-01T22:01:56Z

addons/aircraft/functions/fnc_gau8_muzzleEffect.sqf

@@ -0,0 +1,42 @@
+/*
+ * Author: Alexus, Zabuza, SzwedzikPL, Sargken
+ * GAU-8 muzzle effect


Missing closing point.

jonpas · 2016-10-01T22:02:40Z

addons/aircraft/config.cpp

+    };
+    class Explosion1
+    {


Opening braces should be on same line as class name.

jonpas · 2016-10-01T22:03:07Z

addons/aircraft/config.cpp

+#include "RscInGameUI.hpp"
+
+class ACE_Gau8ShellImpact {


I think this class is big enough to be put in its own file now.

Effects.hpp

See: https://github.com/acemod/ACE3/blob/e7bc2e9d62aebd5e3d64b45900bebe1433812dcb/addons/grenades/Effects.hpp

jonpas · 2016-10-01T22:04:03Z

addons/aircraft/CfgSoundShaders.hpp

+class CfgSoundShaders {
+    class ACE_GAU8_30mm_closeExp_SoundShader {
+        samples[] = {
+            {PATHTOF(sounds\ammo\GAU8_Hit1),1},


Missing quotes. Use QPATHTOF() instead.

jonpas · 2016-10-01T22:05:13Z

addons/aircraft/CfgAmmo.hpp

+        caliber = 4.1700001;
+        airFriction = -0.00036000001;
+        explosive = 0.34999999;
+        soundHit1[] = {PATHTOF(sounds\ammo\GAU8_Hit1),3.1622779,1,2000};


Missing quotes. Use QPATHTOF() instead.

commy2 · 2016-10-01T22:08:38Z

removed tracers, only visible with NVG

no need to remove them entirely. There is a config entry for this:

    class BWA3_B_556x45_Ball;
    class BWA3_B_556x45_Ball_Tracer_Dim: BWA3_B_556x45_Ball {
        nvgOnly = 1;
    };

PabstMirror · 2016-10-01T22:11:00Z

Couldn't we do the gun effects with class GunParticles { instead of a fired EH?

commy2 · 2016-10-01T22:11:51Z

It uses some randomization, pabst
But the fired eh should only be assigned to this plane instead of all Plane.

PabstMirror · 2016-10-01T22:13:06Z

addons/aircraft/CfgWeapons.hpp

-        burst = 1;
-        class LowROF: Mode_FullAuto {
+        displayName = "GAU-8";
+        magazines[] = {"ACE_1174Rnd_GAU8_30mm_Plane_CAS_01_F"};


We should allow it to still take the old magazines or it could break loadout scripts or other mods using this weapon with the old ammo.

jonpas · 2016-10-02T00:13:39Z

addons/aircraft/functions/fnc_gau8_muzzleEffect.sqf


 if (_weapon != "ACE_Gatling_30mm_Plane_CAS_01_F") exitWith {};

-_no = 8 + random 1;
+private _no = 8 + random 1;
+private _i;


There is no need to private this, it's self-privatized because it's used in that for loop.

@jonpas Not true in my experience, though I do use the array syntax of for so that might e why

The incrementor of the for-loop is automatically set to private to the inner scope of the loop:

_i = "banana"; for "_i" from 0 to 2 do { _i = _i; // with or without }; _i -> "banana"

where as:

_i = "banana"; for "_a" from 0 to 2 do { _i = _a; }; _i -> 2

But you are right about the alternative syntax:

_i = "banana"; for [{_i=1},{_i<=2},{_i=_i+1}] do {}; _i -> 3

work-around:

_i = "banana"; for [{private _i=1},{_i<=2},{_i=_i+1}] do {}; _i -> "banana"

jonpas · 2016-10-02T00:14:40Z

addons/aircraft/functions/fnc_gau8_muzzleEffect.sqf

@@ -13,18 +13,19 @@
 * Return value:
 * None
 *
+ * Example:
+ * QUOTE(_this call FUNC(gau8_muzzleEffect));


Should write it out full, eg. [unit, "weapon", "muzzle", "ammo", "magazine", projectile] call ace_aircraft_fnc_gau8_muzzleEffect;

…-master

PabstMirror · 2016-10-02T00:44:06Z

muzzleEffect seems to work if we make it a CfgFunction
See commit: c19ced1

nicolasbadano · 2016-10-02T13:05:10Z

Couldn't we do the gun effects with class GunParticles { instead of a fired EH?

I agree with @PabstMirror

It uses some randomization, pabst

@commy2, the randomization part could very well be stripped; I believe it's not working, because it does:

private _no = 8 + random 1;
for "_i" from 1 to _no do {

I'm not sure how for behaves on this condiction, as _no is never (all amost never) exactly 9 nor exactly 8.

Zabuzard · 2016-10-02T13:47:48Z

I believe this is an artifact from the past. There where some higher values long ago.
Just to make sure: Currently the only difference is if _no is 8 or 9 (and most times it is 8), right?

If that's the case, you can set it to 8 iterations, fix.

The random part inside of the loop is important. But whether the amount of dropped particles is 8 or 9, well this isn't.

sargken · 2016-10-05T21:00:39Z

Any other suggestions?

commy2 · 2016-10-05T21:11:25Z

do this to make the tracers show up with NVG only:
#4497 (comment)

Zabuzard · 2016-10-05T21:28:50Z

Tracer effects of the GAU-8 can not been seen with eye nor with a night vision device; not at day time nor at night time.
I have talked with multiple real A-10C pilots when making the decision of removing the tracer-effect from the vanilla A-10 in ArmA.

commy2 · 2016-10-05T21:40:56Z

Roger. I was mislead by this post:
#4497 (comment)

removed tracers, only visible with NVG

Zabuzard · 2016-10-05T22:14:35Z

Oh. Yeah, that's indeed misleading. I'll remove that from the changelog for the next update^^

sargken · 2016-10-11T18:07:45Z

This is done on my end. If you guys see things that need to be changed lmk. Otherwise it's completed.

Zabuzard · 2016-11-07T16:01:25Z

Status update? :)

sargken · 2016-11-07T16:29:52Z

I think the next release is 8.2 so gotta wait for .9

VKing6 · 2016-11-15T23:23:06Z

addons/aircraft/CfgAmmo.hpp

+        laserLock = 1;
+        hit = 300;
+        indirectHit = 100;
+        indirectHitRange = 3.5;


For reference, the 120mm HE has a hit value of 220 and an indirectHit of 60.
The old indirectHit value was 4.
Are these values sane for a 30mm gatling gun?

I tested it and it's not as bad as I feared. Maybe it can be tweaked later to try to make it less destructive to buildings, but for now it's okay as far as I can tell.

sargken · 2017-03-16T15:19:09Z

@jonpas Anything else that needs to be done?

Zabuzard · 2017-06-18T18:28:46Z

Status update? :)
In the meantime we have published some major updates of the mod. So this ACE-port probably needs to be adjusted to our new version (5.0).
https://github.com/ZabuzaW/MightyGau-8Avenger/releases

Here's a video of the content:
https://www.youtube.com/watch?v=jfRvJrfC_Gw

jonpas · 2017-09-17T22:32:46Z

Hello @sargken and @ZabuzaW, excuse us for the long delay on this. We have been getting information about the realism of this in connection with the massive changes and after going through it all decided this is better living in its own mod. @SilentSpike can probably give some quick information as of why.

Thank you for the wanted contribution nonetheless, we appreciate the effort!

sargken and others added 6 commits September 30, 2016 21:17

First Integration on Enhanced GAU-8

1355a62

Changed mail of author 'Zabuza'

d0e8a74

Finished Port of GAU8

7b14246

Style Fixes

6f09c0a

RHS Integration

a5d525d

Add Name

ca053a4

Forgot to add in my name for the porting of it.

jonpas added kind/feature Release Notes: **ADDED:** needs review labels Oct 1, 2016

jonpas added this to the 3.8.0 milestone Oct 1, 2016

jonpas requested changes Oct 1, 2016

View reviewed changes

jonpas removed the needs review label Oct 1, 2016

PabstMirror reviewed Oct 1, 2016

View reviewed changes

Sweet Code Tweaks

da655e7

jonpas reviewed Oct 2, 2016

View reviewed changes

PabstMirror added 2 commits October 1, 2016 19:19

Merge branch 'master' of https://github.com/sargken/ACE3 into sargken…

38f1a35

…-master

Use muzzelEffect / CfgFunctions

c19ced1

sargken closed this Oct 2, 2016

sargken reopened this Oct 2, 2016

Merge remote-tracking branch 'refs/remotes/acemod/master'

6253145

sargken added 2 commits October 2, 2016 15:52

Cleanup

9c8d4fa

Cleanup 2

4f51da7

thojkooi modified the milestones: 3.8.0, 3.9.0 Oct 8, 2016

VKing6 reviewed Nov 15, 2016

View reviewed changes

thojkooi added the target/next-milestone? label Feb 5, 2017

PabstMirror modified the milestones: 3.9.0, Ongoing Feb 11, 2017

Merge branch 'master' into master

72ef10a

jonpas closed this Sep 17, 2017

jonpas removed the target/next-milestone? label Sep 17, 2017

kymckay mentioned this pull request Aug 2, 2019

Changes A-10/A-164 Cannon Values #7118

Merged

LinkIsGrim removed this from the Ongoing milestone Jul 14, 2023

Add GAU-8 Enhancement #4497

Add GAU-8 Enhancement #4497

Conversation

sargken commented Oct 1, 2016 • edited Loading

jonpas commented Oct 1, 2016 • edited Loading

sargken commented Oct 1, 2016

sargken commented Oct 1, 2016

jonpas commented Oct 1, 2016

Zabuzard commented Oct 1, 2016 • edited Loading

jonpas commented Oct 1, 2016

jonpas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sargken Oct 1, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sargken Oct 1, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonpas Oct 1, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

commy2 commented Oct 1, 2016

PabstMirror commented Oct 1, 2016

commy2 commented Oct 1, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

commy2 Oct 2, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PabstMirror commented Oct 2, 2016

nicolasbadano commented Oct 2, 2016

Zabuzard commented Oct 2, 2016 • edited Loading

sargken commented Oct 5, 2016

commy2 commented Oct 5, 2016

Zabuzard commented Oct 5, 2016

commy2 commented Oct 5, 2016

Zabuzard commented Oct 5, 2016

sargken commented Oct 11, 2016

Zabuzard commented Nov 7, 2016

sargken commented Nov 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sargken commented Mar 16, 2017

Zabuzard commented Jun 18, 2017

jonpas commented Sep 17, 2017

sargken commented Oct 1, 2016 •

edited

Loading

jonpas commented Oct 1, 2016 •

edited

Loading

Zabuzard commented Oct 1, 2016 •

edited

Loading

sargken Oct 1, 2016 •

edited

Loading

sargken Oct 1, 2016 •

edited

Loading

jonpas Oct 1, 2016 •

edited

Loading

commy2 commented Oct 1, 2016 •

edited

Loading

commy2 Oct 2, 2016 •

edited

Loading

Zabuzard commented Oct 2, 2016 •

edited

Loading