Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical Treatment - Fix Checking Pulse progress bar text #7406

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Medical Treatment - Fix Checking Pulse progress bar text #7406

merged 3 commits into from
Jan 9, 2020

Conversation

jonpas
Copy link
Member

@jonpas jonpas commented Jan 5, 2020

When merged this pull request will:

  • Change "Checking Heart Beat..." to "Checking Pulse..." to conform with "Check Pulse" action and setting names.

@IllidanS4
@TBakerBR
@D3L7A01
@classicarma
@dfr1238

Tag other translators as well!

@jonpas jonpas added kind/translation Release Notes: **TRANSLATIONS:** kind/bug-fix Release Notes: **FIXED:** labels Jan 5, 2020
@jonpas jonpas added this to the 3.13.1 milestone Jan 5, 2020
@jonpas jonpas requested a review from commy2 January 5, 2020 20:27
@D3L7A01
Copy link
Contributor

D3L7A01 commented Jan 5, 2020

italian ok

commy2
commy2 approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

German

@LuisFAntonio
Copy link
Contributor

In portuguese: Change "Aferindo Pulso" to "Checando Pulso". Thanks!

LuisFAntonio
LuisFAntonio suggested changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@LuisFAntonio LuisFAntonio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change Portuguese (2952) from "Aferindo Pulso" to "checando pulso"
Edit: Aferindo is correct, but it's extremely formal and you can go a whole life without hearing it.

@jonpas @classicarma
Apply suggestions from code review
a026958 
Co-Authored-By: classic <skyburunave@gmail.com>
jonpas
jonpas commented Jan 6, 2020
View reviewed changes
addons/medical_treatment/stringtable.xml Outdated Show resolved Hide resolved
addons/medical_treatment/stringtable.xml Outdated Show resolved Hide resolved
@jonpas jonpas merged commit 34c24db into master Jan 9, 2020
@bux bux deleted the fix-checking-pulse-string branch January 9, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuisFAntonio LuisFAntonio LuisFAntonio requested changes

@classicarma classicarma classicarma requested changes

@commy2 commy2 commy2 approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:** kind/translation Release Notes: **TRANSLATIONS:**
Projects
ACE3 Medical Focus Feature
Status: Completed
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.
5 participants
@jonpas @D3L7A01 @LuisFAntonio @commy2 @classicarma