Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical - fix the Enoch pilot uniform not taking damage, fix hitpoints test #7527

Merged
merged 4 commits into from
Feb 17, 2020
Merged

Medical - fix the Enoch pilot uniform not taking damage, fix hitpoints test #7527

merged 4 commits into from
Feb 17, 2020

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Feb 15, 2020 •
edited
Loading

When merged this pull request will:

  • Check all units linked by public items instead of public untis
  • HitRightArm was missing (HitLeftArm used twice)

This picks up:

14:58:49 [ACE] (medical) INFO: Checking mans for medical hitpoints [160 units]
14:58:49 [ACE] (medical) WARNING: I_E_Uniform_01_coveralls_F has bad last hitpoint: ["HitFace","HitNeck","HitHead","HitPelvis","HitAbdomen","HitDiaphragm","HitChest","HitBody","HitArms","HitHands","HitLegs","Incapacitated"]
14:58:49 [ACE] (medical) WARNING: I_E_Uniform_01_coveralls_F missing ace hitpoints: ["HitFace","HitNeck","HitHead","HitPelvis","HitAbdomen","HitDiaphragm","HitChest","HitBody","HitArms","HitHands","HitLegs","Incapacitated"]

@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label Feb 15, 2020
@commy2 commy2 added this to the 3.13.1 milestone Feb 15, 2020
@commy2 commy2 changed the title fix the medical hitpoints test fix the medical hitpoints test, fix the Enoch pilot Feb 15, 2020
@commy2
Copy link
Contributor Author

commy2 commented Feb 15, 2020

Should this test run on any machine start?

@PabstMirror PabstMirror changed the title fix the medical hitpoints test, fix the Enoch pilot Medical - fix the Enoch pilot uniform not taking damage, fix hitpoints test Feb 16, 2020
@PabstMirror
Copy link
Contributor

w/ CUP and RHS it's only about 38ms so it's not unreasonable to run on preStart
otherwise we don't have any good way of detecting because gear assign may run later

@commy2
Copy link
Contributor Author

commy2 commented Feb 16, 2020

Run it at preStart.

@PabstMirror PabstMirror merged commit 5a4487f into master Feb 17, 2020
@PabstMirror PabstMirror deleted the fix-medical-hitpoints-test branch February 17, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.

Crew does not take damage while inside WY-55 Czapla
2 participants
@commy2 @PabstMirror