Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ballistics - Remove dispersion changes #7557

Merged
merged 11 commits into from
Feb 28, 2020
Merged

Ballistics - Remove dispersion changes #7557

merged 11 commits into from
Feb 28, 2020

Conversation

Laid3acK
Copy link
Contributor

According with #7532 (comment)

@PabstMirror PabstMirror added this to the 3.13.1 milestone Feb 25, 2020
@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Feb 25, 2020
jonpas
jonpas previously requested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused classes should be left out to clean up the inheritance tree in this file.

@jonpas jonpas changed the title Dispersion removed Ballistics - Remove dispersion changes Feb 26, 2020
@Laid3acK Laid3acK mentioned this pull request Feb 27, 2020
Closed
@Laid3acK
Copy link
Contributor Author

Next Rifle_Base_F clean up.

@Laid3acK
Copy link
Contributor Author

Except if i mistaken somewhere, should fix this issue #7559

@commy2
Copy link
Contributor

commy2 commented Feb 28, 2020

If it does, it does so poorly. Still using magazines[] instead of magwells. So I'd rather keep that issue open until a proper fix.

@commy2 commy2 merged commit f8fbc69 into acemod:master Feb 28, 2020
@jonpas jonpas mentioned this pull request Feb 28, 2020
Closed
@Laid3acK Laid3acK deleted the dispersion_removed branch February 28, 2020 17:22
@commy2 commy2 mentioned this pull request Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedmen dedmen dedmen left review comments

@commy2 commy2 commy2 approved these changes

@jonpas jonpas jonpas left review comments

Assignees
No one assigned
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Milestone
3.13.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Laid3acK @commy2 @dedmen @jonpas @PabstMirror