-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ballistics - Fix DMR_03 (SIG556) initSpeed #7567
Conversation
addons/ballistics/CfgWeapons.hpp
Outdated
magazineWell[] += { | ||
"CBA_762x51_M14" | ||
}; // vanilla magazineWell[] = {"M14_762x51"}; | ||
}; | ||
|
||
class srifle_DMR_03_F: DMR_03_base_F { | ||
initSpeed = -0.991536; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i tested the RC, i saw that the class srifle_DMR_03_F
has his own initSpeed
, 940 if i remember correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, saw that. I think we should keep the value in both classes and put a comment after this line.
Why all the empty lines? |
I believed it was a part of the Coding Guidelines. I'm wrong ? |
addons/ballistics/CfgWeapons.hpp
Outdated
magazineWell[] += { | ||
"CBA_762x51_M14" | ||
}; // vanilla magazineWell[] = {"M14_762x51"}; | ||
}; | ||
|
||
class srifle_DMR_03_F: DMR_03_base_F { | ||
initSpeed = -0.991536; // Default vanilla value 940 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, an explanation why this is here. And also keep the original change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what do you mean with an explanation. There is no explanation with the old config.
And also keep the original change
Same, i don't understand my mistake.
Reverted to the old format for the cfgWeapons (better compatibility with third mods). |
When merged this pull request will:
DMR_03_base_F
initSpeed
.arifle_katiba_Base_F
30 rnd IR-Dim magazine (KH2002 Sama variants).ACE_30Rnd_556x45_Stanag_Tracer_Dim
picture (30 rnd magazine icon instead 20 rnd).