Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realistic Names - Add 2D optics #7571

Merged
merged 2 commits into from
Apr 6, 2020
Merged

Realistic Names - Add 2D optics #7571

merged 2 commits into from
Apr 6, 2020

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Mar 3, 2020

When merged this pull request will:

  • add the ace 2d optics to realistic names.

@jonpas jonpas added this to the 3.13.2 milestone Mar 3, 2020
@jonpas jonpas added area/compatibility kind/enhancement Release Notes: **IMPROVED:** labels Mar 3, 2020
@jonpas jonpas changed the title Add 2D optics to realistic names. Realistic Names - Add 2D optics Mar 3, 2020
@Mike-MF
Copy link
Member Author

Mike-MF commented Mar 3, 2020

https://i.gyazo.com/7fbf67a38b9cf73b012a9aa377bacb0c.png

@Mike-MF Mike-MF closed this Mar 3, 2020
@jonpas
Copy link
Member

jonpas commented Mar 3, 2020

Just require optics. optics only contains added 2D and PIP optics, something one doesn't even have to use. It's not like one is forced to use MILs with it (scopes does that).

And for the rare case of someone wanting to use realisticnames but not optics, we can't satisfy every last 0.00001%.

@Mike-MF Mike-MF reopened this Mar 3, 2020
jonpas
jonpas approved these changes Apr 5, 2020
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint was cancelled for some reason, can't seem to restart, but should be good.

@PabstMirror PabstMirror merged commit 9c4aef3 into acemod:master Apr 6, 2020
@jonpas jonpas mentioned this pull request Apr 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
area/compatibility kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Mike-MF @jonpas @PabstMirror