Cargo - Fix tankx vehicles receiving water damage when loaded #7636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharis001
reviewed
Apr 13, 2020
mharis001
reviewed
Apr 13, 2020
Co-Authored-By: mharis001 <34453221+mharis001@users.noreply.github.com>
mharis001
approved these changes
Apr 13, 2020
Dystopian
reviewed
Apr 14, 2020
Co-Authored-By: Dystopian <sddex@ya.ru>
commy2
approved these changes
Apr 14, 2020
|
does the same also apply to other x vehicles? helicopters, jets? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Some vehicles (in our case the M119A2) receive damage when loaded on terrains with low elevation. This seems to be the same issue as was already solved for any vehicle using carx simulation, but as these vehicles use tankx instead they do not get made invulnerable.
Simply adding an OR statement for tankx is probably not the cleanest solution, but it appears there are only 3 PhysX simulation types in Arma (last being shipx) so it should be ok. Feel free to suggest a different solution otherwise.