Add Weapon Attachments interaction #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharis001
reviewed
May 11, 2020
addons/interaction/functions/fnc_getWeaponAttachmentsActions.sqf
Outdated
Show resolved
Hide resolved
addons/interaction/functions/fnc_getWeaponAttachmentsActions.sqf
Outdated
Show resolved
Hide resolved
addons/interaction/functions/fnc_modifyWeaponAttachmentsAction.sqf
Outdated
Show resolved
Hide resolved
addons/interaction/functions/fnc_getWeaponAttachmentsActions.sqf
Outdated
Show resolved
Hide resolved
|
Any reason this isn't under "Equipment"? There are many things that different components add to the root menu already and this doesn't seem to be anything that has to be done in a quick manner. We need another main interaction point on the weapon on the bottom right. |
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
mharis001
reviewed
May 15, 2020
addons/interaction/functions/fnc_getWeaponAttachmentsActions.sqf
Outdated
Show resolved
Hide resolved
|
ready for review |
mharis001
reviewed
Dec 14, 2020
mharis001
approved these changes
Mar 1, 2021
addons/interaction/functions/fnc_getWeaponAttachmentsActions.sqf
Outdated
Show resolved
Hide resolved
PabstMirror
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
No inventory spacestring fromattach,chemlightsandhearingcomponents tocommon;fnc_cbaSettings_convertHelper;interactionsettings to sqf.This PR ports @mharis001 Attachment Switching mod with some fixes/additions. It adds ability to take weapon attachment off/on or switch it to another one.
To avoid translation string creating and visual separatingtake offfromswitch toactions I used existing stringTake it offand red attachment icon instead of its picture. From all of my tests it looks the best. Of course it can be discussed.String
No inventory spacehas different translation in each component. Only English, German, Polish and Hungarian are the same. If you see some mistakes in other languages suggest correct versions.This PR requires CBATeam/CBA_A3#1330.