Tagging - Add support for mission Tags #7710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
changed the title
dedmen
changed the title
PabstMirror
reviewed
Jun 13, 2020
PabstMirror
reviewed
Jun 13, 2020
PabstMirror
reviewed
Jun 13, 2020
mharis001
reviewed
Jun 13, 2020
| @@ -20,7 +21,8 @@ | |||
| params [ | |||
| ["_unit", objNull, [objNull]], | |||
| ["_texture", "", [""]], | |||
| ["_material", "", [""]] | |||
| ["_material", "", [""]], | |||
| ["_tagModel", "UserTexture1m_F", [""]] | |||
There was a problem hiding this comment.
This is not used anywhere in this function. Should be added to L117 so it is passed to createTag.
There was a problem hiding this comment.
Its not used in the params, but should still be in the header, and adding it to params will make sure that it prints error at correct place if you pass wrong datatype.
L117 is oopsie
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
PabstMirror
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Parse tags from description.ext
It will also handle mission/mod paths just like https://community.bistudio.com/wiki/Description.ext#CfgSounds
This is based on #7709 branch (sorry but they would conflict either way)