Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagging - Add: Support of localized string for tagging interaction #7819

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Tagging - Add: Support of localized string for tagging interaction #7819

merged 3 commits into from
Jul 27, 2020

Conversation

Vdauphin
Copy link
Contributor

20200726115945_1

When merged this pull request will:

  • This pull request check if a string is localize and return the localization if available.
  • If check of ìsLocalize`

@Vdauphin Vdauphin mentioned this pull request Jul 26, 2020
Merged
2 tasks
@PabstMirror
Copy link
Contributor

Might be a tiny bit better to do this in ace_tagging_fnc_applyCustomTag so GVAR(cachedTags) just has localized values

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 26, 2020
@PabstMirror PabstMirror added this to the 3.13.4 milestone Jul 26, 2020
@Vdauphin @mharis001
Update addons/tagging/functions/fnc_applyCustomTag.sqf
9838273 
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
@PabstMirror PabstMirror merged commit d3727d7 into acemod:master Jul 27, 2020
@Vdauphin Vdauphin deleted the patch-3 branch July 27, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.13.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Vdauphin @PabstMirror @veteran29 @mharis001