Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grenades - Add throwable explosive charges #7860

Merged
merged 17 commits into from
Aug 24, 2020
Merged

Grenades - Add throwable explosive charges #7860

merged 17 commits into from
Aug 24, 2020

Conversation

Cyruz143
Copy link
Contributor

@Cyruz143 Cyruz143 commented Aug 19, 2020

Allow conversion of explosives to grenades:

  • Removes explosive and adds a grenade variant with a fixed 7 second fuse
  • Uses CBA context menu (double click on item in inventory)
  • Configs might have some excess fluff in and SQF could probably be better as it seems a bit redundant
  • Adds and ace_explosives requirement (as I'm borrowing the icon). If someone has a better one (or vanilla one I'll remove switch it out)
  • Probably needs a setting adding so people can disable it

Overall this is a bit rough around the edges but is functional (and pretty fun if you like attacking tanks WW2 style)

Old video before I added some torque to the throw: https://gfycat.com/limprareblowfish

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Aug 19, 2020
@jonpas jonpas added this to the 3.14.0 milestone Aug 19, 2020
@jonpas jonpas self-requested a review August 19, 2020 22:37
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing EOL in most of the files. Please use an editor with .editorconfig support to ensure correct code formatting.

addons/grenades/CfgMagazines.hpp Outdated Show resolved Hide resolved
addons/grenades/CfgMagazines.hpp Outdated Show resolved Hide resolved
addons/grenades/CfgMagazines.hpp Outdated Show resolved Hide resolved
addons/grenades/XEH_PREP.hpp Outdated Show resolved Hide resolved
addons/grenades/functions/fnc_changeFuse.sqf Outdated Show resolved Hide resolved
addons/grenades/CfgMagazines.hpp Outdated Show resolved Hide resolved
addons/grenades/XEH_postInit.sqf Outdated Show resolved Hide resolved
@BaerMitUmlaut
Copy link
Member

Satchel charges weigh 20 lbs / 9 kg. You can throw it a bit too far imo.

@Cyruz143
Copy link
Contributor Author

Satchel charges weigh 20 lbs / 9 kg. You can throw it a bit too far imo.

Dropped it down a bit, don't want it to be too small or you sacrifice gameplay vs realism.

Cyruz143 and others added 2 commits August 22, 2020 18:30
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: Elgin675 <elgin675@hotmail.com>
<English>Explosive Satchel (Throwable)</English>
</Key>
<Key ID="STR_ACE_Grenades_SatchelCharge_Description">
<English>Type: Charge&lt;br /&gt;Rounds: 1&lt;br /&gt;Used on: Things that need to die</English>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, simple implementation.

@PabstMirror PabstMirror modified the milestones: 3.14.0, 3.13.4 Aug 23, 2020
Elgin675 and others added 3 commits August 23, 2020 18:05
@Elgin675
Copy link
Contributor

Do you plan to implement an option in cba settings, to enable/disable this feature ?

Co-authored-by: Elgin675 <elgin675@hotmail.com>
@Cyruz143
Copy link
Contributor Author

Do you plan to implement an option in cba settings, to enable/disable this feature ?

I can if required, I'm not sure if it's warrented though?

@Elgin675
Copy link
Contributor

Elgin675 commented Aug 23, 2020

I'm in a serious community, so I'm fine.
But I feel sorry for immature communities, where games could turn into "dynamite hunting" :'(.

That's why I think an option is preferable, if only for the server administrator ;) !

It also changes the gameplay : for some scenarios, the mission maker may want the explosive planting to be longer, and therefore more dangerous.

@PabstMirror
Copy link
Contributor

I changed setting name from ace_grenades_enabled to ace_grenades_convertExplosives to clearer on what it does

@PabstMirror PabstMirror merged commit b215356 into acemod:master Aug 24, 2020
@Cyruz143 Cyruz143 deleted the throwable_charges branch August 30, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants