Explosives - Add CBA settings for max/min/default timer values #7916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharis001
reviewed
Sep 27, 2020
There was a problem hiding this comment.
Should maybe remove the custom timer limits from the docs to prevent CBA settings from being set/changed directly.
Also, what happens if users set the min value higher than the max? Or the default value not within the range?
mharis001
approved these changes
Sep 29, 2020
|
The only downside is this could break old missions using the old But it also will be easy enough to update to the new way |
PabstMirror
approved these changes
Oct 3, 2020
veteran29
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: