Fix Multiple Issues With Timestamps #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
added
kind/enhancement
commy2
force-pushed
the
fix-broken-timestamps
branch
from
37b40c4 to
1447b1b
Compare
jonpas
reviewed
Dec 7, 2020
PabstMirror
reviewed
Feb 4, 2021
|
|
||
| if !(_string select [1, 1] in DIGITS) exitWith {_original}; | ||
| if !(_string select [2, 1] in DIGITS) exitWith {_original}; | ||
| if (_string select [3, 1] != ":") exitWith {_original}; |
There was a problem hiding this comment.
Fails if using "HH" format
There was a problem hiding this comment.
I think we just need to drop this and the next few lines to support time codes like [12]
or just drop HH format
(I'm also not sure I understand why we have "HH:MM:SS:MM" but that's unrelated)
There was a problem hiding this comment.
@commy2 - I commited a fix to this PR, let me know if it looks ok
PabstMirror
reviewed
Feb 18, 2021
|
|
||
| params ["_original"]; | ||
|
|
||
| // @todo, 2.02 reverse command will support STRING types |
There was a problem hiding this comment.
reverse does not like unicode
copies as "�ссѵЀѿ� �добовС�"
There was a problem hiding this comment.
With forceUnicode? Can you please also make a FT ticket for that example if its really broken?
PabstMirror
approved these changes
Feb 26, 2021
|
Thanks for finishing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request that added the auto timestamping to the marker menu was incredibly rushed and broken.
When merged this pull request will:
before
after:
