-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHS Compat - Add ACE_GForceCoef value for DF-15 uniforms #8039
Conversation
This adds missing ACE_GForceCoef value for DF-15 uniforms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the formatting:
- 4 spaces per indentation level.
- Opening brace on same line.
- Spaces around
=
.
And simplify the value to 0.8
.
DF-15 PR - cfgWeapons formating
Forgot to save it with braces and spaces around =
All bulletpoints "fixed", it should be all right. |
lgtm though idk if the class inheritance is correct |
Initialy I tried it with Uniform_Base for all uniforms, but it worked only for saf3 uniforms. I peeked into RHS configs and found out, that for afrf3, they are indeed inheriting it from rhs_uniform_flora. I tried it in-game, it worked without any issues. |
Addition to this, I just looked into saf3 config, and they are inheriting it from Uniform_Base, so it should be all right - this is RHS mess. |
Don't guess inheritance. Always take it from the config you base it on. |
I knew that class from the past, just double-checked it 😅 |
What will happen next? Will it get approved, some changes requiered to be performed, or casted into the void? |
When merged this pull request will: