Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS Compat - Add ACE_GForceCoef value for DF-15 uniforms #8039

Merged
merged 4 commits into from
Dec 31, 2020
Merged

RHS Compat - Add ACE_GForceCoef value for DF-15 uniforms #8039

merged 4 commits into from
Dec 31, 2020

Conversation

YetheSamartaka
Copy link
Contributor

When merged this pull request will:

  • Add missing ACE_GForceCoef value for DF-15 uniforms.
  • ACE_GForceCoef value is the same as for Vanilla counterparts(Many other mods are using these values for their uniforms as well)

This adds missing ACE_GForceCoef value for DF-15 uniforms.
@YetheSamartaka YetheSamartaka changed the title Add DF-15 GForceCoef Value compat_rhs_afrf3 and saf3 - Add DF-15 GForceCoef Value Dec 10, 2020
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the formatting:

  • 4 spaces per indentation level.
  • Opening brace on same line.
  • Spaces around =.

And simplify the value to 0.8.

@mharis001 mharis001 added this to the 3.13.6 milestone Dec 10, 2020
@mharis001 mharis001 changed the title compat_rhs_afrf3 and saf3 - Add DF-15 GForceCoef Value RHS Compat - Add ACE_GForceCoef value for DF-15 uniforms Dec 10, 2020
DF-15 PR - cfgWeapons formating
Forgot to save it with braces and spaces around =
@YetheSamartaka
Copy link
Contributor Author

Please fix the formatting:

* 4 spaces per indentation level.

* Opening brace on same line.

* Spaces around `=`.

And simplify the value to 0.8.

All bulletpoints "fixed", it should be all right.

@commy2
Copy link
Contributor

commy2 commented Dec 10, 2020

lgtm though idk if the class inheritance is correct

@YetheSamartaka
Copy link
Contributor Author

lgtm though idk if the class inheritance is correct

Initialy I tried it with Uniform_Base for all uniforms, but it worked only for saf3 uniforms. I peeked into RHS configs and found out, that for afrf3, they are indeed inheriting it from rhs_uniform_flora. I tried it in-game, it worked without any issues.

@YetheSamartaka
Copy link
Contributor Author

lgtm though idk if the class inheritance is correct

Initialy I tried it with Uniform_Base for all uniforms, but it worked only for saf3 uniforms. I peeked into RHS configs and found out, that for afrf3, they are indeed inheriting it from rhs_uniform_flora. I tried it in-game, it worked without any issues.

Addition to this, I just looked into saf3 config, and they are inheriting it from Uniform_Base, so it should be all right - this is RHS mess.

@commy2
Copy link
Contributor

commy2 commented Dec 10, 2020

Don't guess inheritance. Always take it from the config you base it on.

@YetheSamartaka
Copy link
Contributor Author

Don't guess inheritance. Always take it from the config you base it on.

I knew that class from the past, just double-checked it 😅

@YetheSamartaka
Copy link
Contributor Author

What will happen next? Will it get approved, some changes requiered to be performed, or casted into the void?

@PabstMirror PabstMirror merged commit 718535c into acemod:master Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants