Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Damage - Add setting for unconscious chance from pain #8092

Merged
merged 6 commits into from
Feb 8, 2021
Merged

Medical Damage - Add setting for unconscious chance from pain #8092

merged 6 commits into from
Feb 8, 2021

Conversation

Mike-MF
Copy link
Member

@Mike-MF Mike-MF commented Feb 1, 2021

When merged this pull request will:

  • Changes the default 10% chance of unconsciousness from pain to a slider.

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Feb 1, 2021
@jonpas jonpas added this to the 3.13.6 milestone Feb 1, 2021
@jonpas jonpas requested a review from mharis001 February 1, 2021 23:40
addons/medical_damage/initSettings.sqf Outdated Show resolved Hide resolved
addons/medical_damage/stringtable.xml Outdated Show resolved Hide resolved
addons/medical_damage/stringtable.xml Outdated Show resolved Hide resolved
@Mike-MF Mike-MF requested a review from mharis001 February 2, 2021 01:16
@Mike-MF Mike-MF requested a review from mharis001 February 2, 2021 02:36
ELSTRING(medical,Category),
[0, 1, 0.1, 2, true],
true
] call CBA_settings_fnc_init;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CBA_settings_fnc_init should be replaced with CBA_fnc_addSetting here and above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say do that in separate PR ACE-wide. All medical still uses the old function.

addons/medical_damage/stringtable.xml Show resolved Hide resolved
addons/medical_damage/stringtable.xml Outdated Show resolved Hide resolved
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
@commy2
Copy link
Contributor

commy2 commented Feb 2, 2021

This is not how probabilities work.

Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
@jonpas jonpas merged commit 7a65acd into acemod:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants