Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging - Add more objects configs #8104

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Conversation

Dystopian
Copy link
Contributor

@Dystopian Dystopian commented Feb 11, 2021

When merged this pull request will:

  • add dragging configurations for frequent terrain objects (requires Interaction - Add interaction with terrain objects #8103);
  • add default Position for missing config values;
  • cleanup dragging config a little;
  • change default draggable position from [0,0,0] (useless because it's inside player) to [0,1.5,0] (suits many objects);
  • update documentation according to changes.

Use this code to create new objects for testing:

{createVehicle [_x, player]} forEach ["Land_BarrelSand_F","Land_BarrelWater_F","Land_Basket_F","Land_Bucket_F","Land_CampingChair_V1_folded_F","Land_CampingTable_F","Land_CampingTable_small_F","Land_CanisterPlastic_F","Land_CratesPlastic_F","Land_GarbageBarrel_01_english_F","Land_GarbageContainer_closed_F","Land_GarbageContainer_open_F","Land_MetalBarrel_empty_F","Land_MetalBarrel_F","Land_Pallet_F","Land_Pallet_vertical_F","Land_Pallets_F","Land_Sun_chair_F","Land_TablePlastic_01_F","Land_Tyre_F","Land_WheelCart_F","Land_WoodenCart_F","Land_WoodenTable_large_F","Land_WorkStand_F"];

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Apr 20, 2021
@jonpas jonpas added this to the 3.14.0 milestone Apr 20, 2021
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this right away if you split off terrain replacement config into that other existing PR.

docs/wiki/framework/dragging-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/dragging-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/dragging-framework.md Outdated Show resolved Hide resolved
addons/dragging/functions/fnc_setDraggable.sqf Outdated Show resolved Hide resolved
addons/dragging/functions/fnc_setDraggable.sqf Outdated Show resolved Hide resolved
addons/dragging/functions/fnc_initObject.sqf Outdated Show resolved Hide resolved
addons/dragging/functions/fnc_initObject.sqf Outdated Show resolved Hide resolved
@Dystopian
Copy link
Contributor Author

I removed replacing config so this PR should be merged before #8103, then I re-add changes there.

I also added test code to description to create all new objects.

@Dystopian Dystopian requested a review from jonpas May 3, 2021 10:45
@jonpas jonpas modified the milestones: 3.14.1, 3.14.0 May 3, 2021
docs/wiki/framework/dragging-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/dragging-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/dragging-framework.md Outdated Show resolved Hide resolved
docs/wiki/framework/dragging-framework.md Outdated Show resolved Hide resolved
@jonpas jonpas merged commit ad41bf2 into acemod:master Jul 23, 2021
@Dystopian Dystopian deleted the add-drag-objects branch July 23, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants