-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookOff - Fix: Disable ammunition cookoff and turret effect when skipping destruction effects #8122
Conversation
Can we also check the same thing in normal cookoff? I didn't check, but I think if you do |
When you do Also you might want to set 0.99 damage without effect and let Arma behave normaly? |
Well this is really besides the point. If we can't know that, we can't, it was just a question. |
addons/cookoff/XEH_postInit.sqf
Outdated
params ["_vehicle", "", "", "_useEffects"]; | ||
if ( | ||
_vehicle getVariable [QGVAR(enableAmmoCookoff), GVAR(enableAmmoCookoff)] && | ||
_useEffects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the shorter condition first would be a bit more readable imho _useEffects &&
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also combine the if
exitWith
below into this as well.
When merged this pull request will:
cursorObject setDamage [1, false]
to destroy an object by skipping destruction effects the ammunition still cookoff