Add Fire component #8245
Merged
Add Fire component #8245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
PabstMirror
reviewed
May 25, 2021
PabstMirror
reviewed
May 25, 2021
PabstMirror
reviewed
May 25, 2021
|
Not ready for 3.14.0 @PabstMirror ? |
|
We've been using this for months |
jonpas
requested changes
Jul 23, 2021
| @@ -0,0 +1,19 @@ | |||
| [ | |||
| QGVAR(enabled), "CHECKBOX", | |||
There was a problem hiding this comment.
One is "enabled", the other (flare) is "enable". Not sure what we use most of the time (former I think), but both should be the same.
Settings are really the only thing I want double-checked before merge, so we can avoid changing them later if at all possible.
jonpas
reviewed
Jul 23, 2021
jonpas
approved these changes
Jul 23, 2021
kymckay
reviewed
Aug 18, 2021
kymckay
reviewed
Aug 18, 2021
Actually it is not. |
Correct, that's in #7565. |
jonpas
requested changes
Oct 12, 2021
Co-authored-by: Kyle Mckay <kymckay.dev@gmail.com>
jonpas
approved these changes
Oct 12, 2021
jonpas
added a commit
to Theseus-Aegis/ACE3
that referenced
this pull request
Oct 13, 2021
…Control' and 'acex-merge' into tac-3.14.0-pre acemod#8245 acemod#7565 acemod#8064 acemod#8273 acemod#8415
jonpas
added
kind/feature
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
* merge fire * Change required addons. Change getPos to getPosASL. Remove include * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Kyle Mckay <kymckay.dev@gmail.com> * Update addons/fire/stringtable.xml Co-authored-by: jonpas <jonpas33@gmail.com> Co-authored-by: Kyle Mckay <kymckay.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
firemodule (deprecates Port ACE2 burning #4131)AddAdd Vehicle Damage (ACE2 port) & Enhance Cook-Off #7565thermal_burndamage type tomedical_damage