Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging - Remove never used parameter on doAnimation call #8342

Merged

Conversation

severgun
Copy link
Contributor

When merged this pull request will:

  • Remove 4th never used parameter on doAnimation call

label: "ignore changelog" needed

Copy link
Contributor

@commy2 commy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This argument does nothing, because the function only has 3 parameters.

@commy2 commy2 added ignore-changelog Release Notes: Excluded kind/cleanup Release Notes: **CHANGED:** labels Jul 30, 2021
@commy2 commy2 added this to the 3.14.0 milestone Jul 30, 2021
@severgun
Copy link
Contributor Author

Oh. Maybe PR sould be renamed to Dragging- ...

@jonpas jonpas removed the ignore-changelog Release Notes: Excluded label Jul 31, 2021
@jonpas jonpas changed the title Common - Remove never used parameter on doAnimation call Dragging - Remove never used parameter on doAnimation call Jul 31, 2021
@PabstMirror PabstMirror merged commit 3827178 into acemod:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants