Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaserPointer - Adds workaround to make Visible lasers work with ballistic shields #8418

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

10Dozen
Copy link
Contributor

@10Dozen 10Dozen commented Sep 1, 2021

When merged this pull request will:

  • Title.

Note:
Currently visibility of the visible laser point is calculated using Fire Geomety LOD. When used with ballistic shields (e.g. one from the CUP), that has mesh in the Fire Geometry that covers head (e.g. with bulletproof glass), laser is not drawn at all.
This commit alternates the calculation for laser radiated by the player - in this case View Geomtery LOD is used. This allows to make Fire Geo to cover head from bullets, and View Geo to have a viewport that doesn't block LOS to laser.
For other lasers (radiated by other players) Fire Geo LOD is always used.

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Sep 1, 2021
@jonpas jonpas added this to the 3.14.0 milestone Sep 1, 2021
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well with newish CUP ballistic shields

@PabstMirror PabstMirror changed the title Adds workaround to make Visible lasers work with ballistic shields LaserPointer - Adds workaround to make Visible lasers work with ballistic shields Oct 7, 2021
@PabstMirror PabstMirror merged commit f232f84 into acemod:master Oct 7, 2021
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants