Common - Add settings for additional progress bar information #8428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ACE_Settings.hpp
LinkIsGrim
force-pushed
the
additional-progressbar-info
branch
from
383b657 to
7c8865c
Compare
PabstMirror
reviewed
Oct 7, 2021
|
I know grad trenches did something funny with ace's progressBar, but as far as I can tell this should work fine with it. |
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
…al-progressbar-info
LinkIsGrim
commented
Oct 7, 2021
LinkIsGrim
commented
Oct 7, 2021
Didn't use this with that yet, but worst that can happen is not showing the extra info. I think they use a modified version of the progressBar function. |
jonpas
requested changes
Oct 10, 2021
|
Was for keeping things consistent with existing strings. Will adjust. |
PabstMirror
approved these changes
Oct 10, 2021
jonpas
approved these changes
Oct 10, 2021
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
…#8428) Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: