Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Use engine hashmaps #8468

Merged
merged 6 commits into from
Oct 10, 2021
Merged

General - Use engine hashmaps #8468

merged 6 commits into from
Oct 10, 2021

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Oct 1, 2021 •
edited
Loading

When merged this pull request will:

  • Switch CBA hashes to engine hashmaps.
  • Minor optimization in arsenal_fnc_scanConfig.
  • Minor optimizations in overheating component.

@LinkIsGrim LinkIsGrim changed the title WIP - Various - Use engine hashmaps Various - Use engine hashmaps Oct 1, 2021
@LinkIsGrim LinkIsGrim marked this pull request as ready for review October 1, 2021 23:00
@jonpas jonpas added the kind/optimization Release Notes: **IMPROVED:** label Oct 2, 2021
@jonpas jonpas added this to the 3.14.0 milestone Oct 2, 2021
LinkIsGrim and others added 2 commits October 2, 2021 18:02
@LinkIsGrim @dedmen
whoops
b2bd7c7 
Co-authored-by: Dedmen Miller <dedmen@users.noreply.github.com>
@LinkIsGrim
compare hashmaps properly
69d342d
@jonpas jonpas changed the title Various - Use engine hashmaps General - Use engine hashmaps Oct 10, 2021
jonpas
jonpas approved these changes Oct 10, 2021
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jonpas jonpas removed the status/WIP label Oct 10, 2021
@jonpas jonpas merged commit 97deef5 into acemod:master Oct 10, 2021
@Whigital Whigital mentioned this pull request Oct 11, 2021
Closed
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
@LinkIsGrim @dedmen @AndreasBrostrom
General - Use engine hashmaps (acemod#8468)
bad52bd 
Co-authored-by: Dedmen Miller <dedmen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 left review comments

@dedmen dedmen dedmen left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
5 participants
@LinkIsGrim @dedmen @jonpas @PabstMirror @mharis001