Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arsenal - Fix sortPanel clearing custom item names #8478

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Arsenal - Fix sortPanel clearing custom item names #8478

merged 1 commit into from
Oct 5, 2021

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • title, sortPanel would reset any custom item name set through panel filled event handlers by getting the name from config again
    • Used by ACE dogtags and ACRE radios
  • Fix sortPanel not using correct item config in rare cases

@mharis001 mharis001 added the kind/bug-fix Release Notes: **FIXED:** label Oct 3, 2021
@mharis001 mharis001 added this to the 3.14.0 milestone Oct 3, 2021
@mharis001 mharis001 merged commit 09d1284 into master Oct 5, 2021
@mharis001 mharis001 deleted the arsenal-custom-names branch October 5, 2021 19:37
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
@mharis001 @AndreasBrostrom
Arsenal - Fix sortPanel clearing custom item names (acemod#8478)
74b2d66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mharis001 @jonpas