-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common - Fix calling getVar on null object in canInteractWith
#8532
Conversation
Only with -debug mode enabled, and it got disabled when default value is provided (which you have) or unscheduled (which you have too) TLDR this RPT warning won't happen for you there. So both changes harm performance (eeeever so slightly) and are not needed. |
@PabstMirror revert? :D |
yeah |
…od#8532) * Common - Fix calling getVar on null object in `canInteractWith` * why was this added dedman?
…h` (acemod#8532)" (acemod#8564) This reverts commit a0e9f60.
Prime a grenade in adv_tossing and it spams rpt with
there is a call with null target
and in 2.06 calling getVar on a null throws rpt warning (but no popup even with showscript debug)
edit: this is a profiling branch thing