Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHS USAF Compat - Add RHS Jerrycan as usable Jerrycan #8603

Merged
merged 5 commits into from
Oct 25, 2021
Merged

RHS USAF Compat - Add RHS Jerrycan as usable Jerrycan #8603

merged 5 commits into from
Oct 25, 2021

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Oct 24, 2021 •
edited
Loading

Its a 20L fuel jerrycan

Add RHS Jerrycan compat.

  • Make it act as Jerrycan
  • Make it cargo loadable

@dedmen
Copy link
Contributor Author

dedmen commented Oct 24, 2021 •
edited
Loading

I found it odd that you couldn't load a 20L jerrycan into a vehicle cargo so I added that.
But that brings up the question why the vanilla jerrycan wasn't made loadable.
They are also not carryable, but "Take Fuel Nozzle" kinda does that.
On the other hand "Take Fuel Nozzle" has quite a long progressbar timer on it, which doesn't make sense for literally just picking up a jerrycan thats standing on the ground, and with fuel nozzle in hand you can only walk, while you should be able to run with a 20L jerrycan in your hands.

And I also found the flexible 300L fueltanks in vanilla which are also not loadable, I think they should be?
Flexi tanks: #8604

@veteran29 veteran29 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 24, 2021
veteran29
veteran29 approved these changes Oct 24, 2021
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veteran29 veteran29 added this to the Ongoing milestone Oct 24, 2021
@jonpas jonpas changed the title Add RHS Jerrycan as usable Jerrycan RHS USAF Compat - Add RHS Jerrycan as usable Jerrycan Oct 24, 2021
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.14.1 Oct 25, 2021
@PabstMirror PabstMirror merged commit b36dac7 into acemod:master Oct 25, 2021
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
@dedmen @jonpas @AndreasBrostrom
RHS USAF Compat - Add RHS Jerrycan as usable Jerrycan (acemod#8603)
a76cf31 
* Add RHS Jerrycan as usable Jarrycan

* Make RHS Jerrycan cargo loadable

* Support both jerrycan camo's

* Add missing canLoad property

* Update optionals/compat_rhs_usf3/CfgVehicles.hpp

Co-authored-by: jonpas <jonpas33@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@jonpas jonpas jonpas approved these changes

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.14.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dedmen @veteran29 @jonpas @PabstMirror