Medical - Add check to FullHealLocal in case unit is burning then extinguish before healing #8622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabstMirror
reviewed
Oct 25, 2021
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
|
I noticed that the I assume the real solution would be to make the exit of the burn PFH reset the |
jonpas
approved these changes
Oct 28, 2021
PabstMirror
approved these changes
Oct 30, 2021
MiszczuZPolski
pushed a commit
to MiszczuZPolski/ACE3
that referenced
this pull request
Nov 5, 2021
…inguish before healing (acemod#8622) * added check if burning in fullheal and then extinguish * Add check if fire module is loaded as PabstMirror showed Co-authored-by: PabstMirror <pabstmirror@gmail.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
…inguish before healing (acemod#8622) * added check if burning in fullheal and then extinguish * Add check if fire module is loaded as PabstMirror showed Co-authored-by: PabstMirror <pabstmirror@gmail.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
…inguish before healing (acemod#8622) * added check if burning in fullheal and then extinguish * Add check if fire module is loaded as PabstMirror showed Co-authored-by: PabstMirror <pabstmirror@gmail.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
AndreasBrostrom
pushed a commit
to AndreasBrostrom/ACE3
that referenced
this pull request
Dec 3, 2021
…inguish before healing (acemod#8622) * added check if burning in fullheal and then extinguish * Add check if fire module is loaded as PabstMirror showed Co-authored-by: PabstMirror <pabstmirror@gmail.com> Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
This will fix the issue described in #8621. It makes full heal extinguish the unit if on fire before healing it. This avoids the issue of a unit on fire that can't be put out by Zeus.
It adds a check to the full heal, if unit is on fire, it sets intensity to 0, which stops the fire.