Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Setting category cleanup #8640

Merged
merged 3 commits into from
Oct 30, 2021
Merged

General - Setting category cleanup #8640

merged 3 commits into from
Oct 30, 2021

Conversation

PabstMirror
Copy link
Contributor

  • Localize ACE Uncategorized
  • Add subcategories for everything in Uncategorized
    Helps to organize and give context to setting
  • Put colors in subCategory (alphabetically last)
    For example half of the verticle height of medical setting category is color settings, so I think it's best to group together
  • Add extra info on ViewDistance settings descriptions
  • Move all settings to initSettings.sqf

- Localize ACE Uncategorized
- Add subcategories for everything in Uncategorized
- Put colors in subCategory (alphabetically last)
- Add extra info on ViewDistance settings descriptions
- Move all settings to initSettings.sqf
@PabstMirror PabstMirror added the kind/cleanup Release Notes: **CHANGED:** label Oct 27, 2021
@jonpas jonpas requested a review from mharis001 October 28, 2021 13:02
@jonpas jonpas added this to the 3.14.1 milestone Oct 28, 2021
@@ -0,0 +1,17 @@
private _category = [LELSTRING(common,ACEKeybindCategoryCommon), QUOTE(COMPONENT_BEAUTIFIED)];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMPONENT_BEAUTIFIED is not localized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will at least match the pbo name

@PabstMirror PabstMirror merged commit 9c94672 into master Oct 30, 2021
@PabstMirror PabstMirror deleted the settingCatColors branch October 30, 2021 21:42
AndreasBrostrom pushed a commit to AndreasBrostrom/ACE3 that referenced this pull request Dec 3, 2021
* General - Setting category cleanup

- Localize ACE Uncategorized
- Add subcategories for everything in Uncategorized
- Put colors in subCategory (alphabetically last)
- Add extra info on ViewDistance settings descriptions
- Move all settings to initSettings.sqf

* Update initSettings.sqf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants