Weather - Fix calculateRoughnessLength detecting buildings above sea level
#8709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commy2
added
status/needs-testing
status/WIP
kind/bug-fix
PabstMirror
approved these changes
Nov 29, 2021
PabstMirror
changed the title
calculateRoughnessLength detecting buildings above sea level
PabstMirror
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
nearObjectsapparenlty takes PosAGL, while the functions takes PosASL.I am pretty sure it actually doesn't matter which position you provide and
nearObjectsactually ignores z entirely.This would mean being 1000 meters above a town would give you high "roughness", even though you are well above the buildings.
Seems like the function is half assed and does not take building height into account at all. Could add a distance check to the buildings, but to be completely sure, you likely have to take building geometry into account.
Ngl, I am salty that half-assed stuff like this is in ACE. Would appreciate if anyone has a solution for this.