Nametags - Fix ACE nametag drawIcon3D parameter error when player controlled unit dies

[Vdauphin]

When merged this pull request will:

• fix ACE nametag drawIcon3D parameter error when player controlled unit dies #8719
• Make sure _icon is never nil
• Looks like when a unit (player or IA) is killed, the rank return "" just before the ACE nametags disappear

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[commy2]

This function is horrenduous. While this probably fixes the issue, it only makes the thing even worse. I'd prefer if someone refactors this.

[Vdauphin]

No time here to rewrite it.

[commy2]

This breaks object namespace icons. As suspected, the logic is broken.

[commy2]

    params ["_player", "_target", "_alpha", "_heightOffset", "_drawName", "_drawRank", "_drawSoundwave"];

    private _targetIcon = _target getVariable QGVAR(rankIcon);

    private _icon = switch true do {
        case _drawSoundwave: {
            format [QPATHTOF(UI\soundwave%1.paa), floor random 10]
        };

        case !_drawRank: {""};
        case !isNil "_targetIcon": {_targetIcon};
        case rank _target == "": {""};

        default {
            private _targetFaction = _target getVariable [QGVAR(faction), faction _target];
            private _customRankIcons = GVAR(factionRanks) getVariable _targetFaction;

            if (!isNil "_customRankIcons") then {
                _customRankIcons param [ALL_RANKS find rank _target, ""] // return
            } else {
                // default rank icons
                format ["\A3\Ui_f\data\GUI\Cfg\Ranks\%1_gs.paa", rank _target] // return
            };
        };
    };

.

[LinkIsGrim]

Does this need testing?

[Vdauphin]

I tested after committing if I remember correctly

[Vdauphin]

Tested when getting closer to unit and when units get killed