Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation - Korean v2.0 #8768

Merged
merged 9 commits into from
Jan 12, 2022
Merged

Translation - Korean v2.0 #8768

merged 9 commits into from
Jan 12, 2022

Conversation

jtj5283449
Copy link
Contributor

When merged this pull request will:

  • Will translate over 1000 lines which wasn't translated before
  • Minor adjustments and synchronization between some gears and items name so it can go smooth with vanilla items (Needs more time to overhaul the translation)

@PabstMirror
Copy link
Contributor

I don't understand the diff, did the encoding change?

@bux
Copy link
Member

bux commented Jan 10, 2022

@jtj5283449 There's something wrong with the files you've committed.
image
That's a lot of changed lines :)

@jtj5283449
Copy link
Contributor Author

my apologies, I don't know how to github and as you can tell I got a brain made with cinderblock. I simply uploaded xml files into my clone and requested merge. I guess I should've done something else

@PabstMirror PabstMirror added this to the 3.14.2 milestone Jan 12, 2022
@PabstMirror PabstMirror added the kind/translation Release Notes: **TRANSLATIONS:** label Jan 12, 2022
@PabstMirror
Copy link
Contributor

Mass replaced \r\n with \n
probably happened because files were uploaded
imho this is not a problem we should have had to deal with, github.com should be smart enough to handle that

@PabstMirror PabstMirror merged commit 4d53d9c into acemod:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants