Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Change object config lookups to configOf #8795

Merged
merged 13 commits into from
Mar 9, 2022

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Jan 26, 2022

When merged this pull request will:

  • Title.
  • Switch out count loops with forEach where appropriate.
  • Add additional TRACE macro in interact_menu_fnc_userActions_addHouseActions.
  • Change some yoda boolean comparisons.

This isn't every object config lookup in the project, but the ones I didn't touch aren't bothersome or are more trouble than they're worth.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PabstMirror PabstMirror added this to the 3.14.2 milestone Jan 30, 2022
@PabstMirror PabstMirror added the kind/optimization Release Notes: **IMPROVED:** label Jan 30, 2022
addons/captives/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/common/functions/fnc_getVehicleIcon.sqf Outdated Show resolved Hide resolved
addons/explosives/functions/fnc_setupExplosive.sqf Outdated Show resolved Hide resolved
addons/logistics_wirecutter/functions/fnc_isFence.sqf Outdated Show resolved Hide resolved
addons/logistics_wirecutter/functions/fnc_isFence.sqf Outdated Show resolved Hide resolved
addons/modules/XEH_postInit.sqf Outdated Show resolved Hide resolved
addons/pylons/XEH_postInit.sqf Outdated Show resolved Hide resolved
LinkIsGrim and others added 10 commits January 30, 2022 21:08
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
@LinkIsGrim LinkIsGrim requested a review from veteran29 February 1, 2022 19:23
@PabstMirror PabstMirror merged commit 68ed199 into acemod:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants