XM157 (NGSW-FC Smart Scope) Framework #8897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
reviewed
May 3, 2022
rautamiekka
reviewed
May 3, 2022
Comment on lines
+43
to
+45
| private _gravity = [-sin (_bank) * cos(_scopeBaseAngle + _inclinationAngle) * -GRAVITY, | ||
| sin(_scopeBaseAngle + _inclinationAngle) * -GRAVITY, | ||
| cos (_bank) * cos(_scopeBaseAngle + _inclinationAngle) * -GRAVITY]; |
There was a problem hiding this comment.
Suggested change
| private _gravity = [-sin (_bank) * cos(_scopeBaseAngle + _inclinationAngle) * -GRAVITY, | |
| sin(_scopeBaseAngle + _inclinationAngle) * -GRAVITY, | |
| cos (_bank) * cos(_scopeBaseAngle + _inclinationAngle) * -GRAVITY]; | |
| private _angleGravity = (_scopeBaseAngle + _inclinationAngle) * -GRAVITY; | |
| private _gravity = [-sin (_bank) * cos (_angleGravity), | |
| sin (_angleGravity), | |
| cos (_bank) * cos (_angleGravity)]; |
(_angleGravity might be an unimaginative or even a misleading name, though.)
There was a problem hiding this comment.
don't want GRAVITY in that term
There was a problem hiding this comment.
this func base very closely on https://github.com/acemod/ACE3/blob/master/addons/atragmx/functions/fnc_calculate_solution.sqf#L61
tbh I'm not really sure why that modifies gravity instead of initial velocity, but I trust ulteq's work so I'd like to keep this func as close to that as possible
rautamiekka
reviewed
May 3, 2022
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
|
demo of menu https://www.youtube.com/watch?v=qYJwUBlGFsc I know they talked about being able to draw any reticle because it's a lcd screen, |
PabstMirror
changed the title
PabstMirror
changed the title
looks like CUP modifies EtelkaMonospaceProBold for some reason??
veteran29
reviewed
Aug 28, 2022
BrettMayson
pushed a commit
to BrettMayson/ACE3
that referenced
this pull request
Oct 10, 2022
* XM157 (NGSW-FC Smart Scope) * Update addons/common/functions/fnc_rscObjectHelper.sqf Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> * Update addons/xm157/functions/fnc_weaponInfo_draw.sqf Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> * Headers * Handle prone-deploy weapon bank * Disable Reticle picker for now * some localizations * Change font looks like CUP modifies EtelkaMonospaceProBold for some reason?? * Create xm157-framework.md * Formating Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
RusComBear
pushed a commit
to RusComBear/ACE3
that referenced
this pull request
Dec 29, 2023
* XM157 (NGSW-FC Smart Scope) * Update addons/common/functions/fnc_rscObjectHelper.sqf Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> * Update addons/xm157/functions/fnc_weaponInfo_draw.sqf Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> * Headers * Handle prone-deploy weapon bank * Disable Reticle picker for now * some localizations * Change font looks like CUP modifies EtelkaMonospaceProBold for some reason?? * Create xm157-framework.md * Formating Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds XM157 NGSW Fire Control Optic
Scope with integrated rangefinder and ballistic computer
Sorta using cba scripted optics, but a lot of it redone for ctrlObject so I can do proper rotation
Demo: https://www.youtube.com/watch?v=mgtT4ZBFJvU
ToDo:
3d Model???
POI marking and sharing (sounds a lot like ace_finger, can share targets via short-range wireless)
This thing isn't released so some assumptions are made as to how it works.
Some References: