Medical - Add AI Unconsciousness exception (when using zeus module)

[YetheSamartaka]

• Adds AI Unconsciousness exception option. It allows you to put AI into unconsciousness via Zeus Module even though the AI unconsciousness is disabled. This "feature" was possible before the medical rewrite and allowed to put selected AI units into unconsciousness even though the overall AI unconsciousness was disabled. This was very handy and many groups missed this ability including myself.
• Special thanks to Pterolatypus for consultation.

[LinkIsGrim]

I'd refactor this to handle the entirety of the statemachine condition inside a function if one is going to be called at all.

Don't particularly like the variable name, but meh.

Change in the Zeus module function should use EGVAR macro.

[YetheSamartaka]

I'd refactor this to handle the entirety of the statemachine condition inside a function if one is going to be called at all.

Don't particularly like the variable name, but meh.

Change in the Zeus module function should use EGVAR macro.

1. I tried to have that _this getVariable and so on inside the statemachine condition, but I have encountered difficulties.
2. I'm aware that it is not the best variable name. I'm open to suggestions.
3. Do you mean replacing the ace_medical_statemachine_AIUnconsciousness_Exception by the EGVAR(medical_statemachine,AIUnconsciousness_Exception)?

[mharis001]

I don't think this should have a setting; it seems confusing. If the only goal is to allow for unconsciousness to be forced (for the Zeus module), let's add logic that specifically allows that without requiring a setting to be set.

[kymckay]

I don't think this should have a setting; it seems confusing. If the only goal is to allow for unconsciousness to be forced (for the Zeus module), let's add logic that specifically allows that without requiring a setting to be set.

Was about to comment the exact same, a setting adds no value here. If we add the logic and someone doesn't want to unconscious AI via zeus they can just not do it.

[YetheSamartaka]

I don't think this should have a setting; it seems confusing. If the only goal is to allow for unconsciousness to be forced (for the Zeus module), let's add logic that specifically allows that without requiring a setting to be set.

Was about to comment the exact same, a setting adds no value here. If we add the logic and someone doesn't want to unconscious AI via zeus they can just not do it.

As requested, the addon option was removed. I've also adjusted the variable name.

[kymckay]

Minor stuff, you/others may disagree so feel free to justify/challenge 😃

[YetheSamartaka]

Minor stuff, you/others may disagree so feel free to justify/challenge 😃

I actually agree with the option being removed. I included it here because I thought that someone might want to have an option to retain current behavior. The variable name was also very horrible initially.

[mharis001]

How does this work with the CardiacArrest state, which has a similar condition?

[YetheSamartaka]

How does this work with the CardiacArrest state, which has a similar condition?

This exception only targets the Zeus module for unconsciousness, so it should not affect the CardiacArrest at all. I've tested it in-game and it hasn't caused any issues. Tried both enabled and disabled AI unconsciousness and it behaved as expected.