Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging - Add more tags #8908

Merged
merged 5 commits into from
May 17, 2022
Merged

Tagging - Add more tags #8908

merged 5 commits into from
May 17, 2022

Conversation

pterolatypus
Copy link
Contributor

When merged this pull request will:

  • Added 10 new tags in each colour
  • Tags are now grouped by required item in the interaction menu
Screenshots

20220512012600_1

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror
Copy link
Contributor

I think we should make the action icons the same as the tag (make config icon the same as texture)
imho it's faster and easier to find what you want (especially since text is cut off sometimes)
Untitled

@PabstMirror PabstMirror added this to the 3.14.2 milestone May 12, 2022
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label May 12, 2022
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@pterolatypus
Copy link
Contributor Author

make the action icons the same as the tag

Sounds fine to me, gives you a nice preview.
We could also consider removing the colour from the name, as it's now pretty clear from other factors.

@jonpas
Copy link
Member

jonpas commented May 12, 2022

Agreed, colour from the name should be removed. It's already in the icon and the higher-level action point.

@pterolatypus
Copy link
Contributor Author

I've left the colour in the "X Red" et al for now, since I think just "X" looks a bit weird

@PabstMirror
Copy link
Contributor

This kinda takes your hash stuff and merges it with GVAR(cachedRequiredItems)
b110bc9
makes ace_tagging_fnc_addTagActions ~8x faster
let me know if this looks ok to push (besides header)

@Drofseh
Copy link
Contributor

Drofseh commented May 13, 2022

I've left the colour in the "X Red" et al for now, since I think just "X" looks a bit weird

I have some concerns for colour blind people, but I think as long as Spray Paint (Red) still has the colour then X Red can just be X

@654wak654
Copy link
Contributor

Could call it X Symbol

@PabstMirror PabstMirror merged commit 699e286 into acemod:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants