Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overpressure - Fix backblast originating at projectile #8985

Merged
merged 8 commits into from
Aug 1, 2022
Merged

Overpressure - Fix backblast originating at projectile #8985

merged 8 commits into from
Aug 1, 2022

Conversation

Whigital
Copy link
Contributor

When merged this pull request will:

  • Add backblast offset to shoulder launchers
  • Change overpressure cache from missionNamespace vars to a hashMap
  • Update docs with new ace_overpressure_offset attribute

Fix #8979

kymckay
kymckay approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@kymckay kymckay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, even updated the docs 👍

Haven't verified that all of your updated config values make sense, but I trust you tested those to set them all.

@mharis001 mharis001 added the kind/enhancement Release Notes: **IMPROVED:** label Jul 27, 2022
@PabstMirror PabstMirror added this to the 3.15.1 milestone Jul 31, 2022
@kymckay kymckay merged commit fc17697 into acemod:master Aug 1, 2022
@kymckay
Copy link
Member

kymckay commented Aug 1, 2022

Re-reviewed, thank you for such a well-packaged contribution 😃

@Whigital Whigital deleted the overpressure_offset branch August 1, 2022 17:49
RusComBear pushed a commit to RusComBear/ACE3 that referenced this pull request Dec 29, 2023
@Whigital @RusComBear
Overpressure - Fix backblast originating at projectile (acemod#8985)
0f2c002 
* Overpressure - Fix backblast originating at the projectile

* RHSUSF - Improve backblast for shoulder launchers

* RHSAFRF - Improve backblast for shoulder launchers

* RHSGREF - Improve backblast for shoulder launchers

* RHSSAF - Improve backblast for shoulder launchers

* Overpressure - Simplify projectile offset and cache lookups

* Overpressure - Remove parentheses and use array as hash key

* Overpressure - Rename caching function and move lookup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 left review comments

@commy2 commy2 commy2 left review comments

@kymckay kymckay kymckay approved these changes

@Dystopian Dystopian Dystopian left review comments

@rautamiekka rautamiekka rautamiekka left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.15.1
Development

Successfully merging this pull request may close these issues.

Rocket launcher back-blast incorrectly starts at front of launcher
7 participants
@Whigital @kymckay @rautamiekka @Dystopian @commy2 @PabstMirror @mharis001