Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo - Add setting for carry after cargo unload #8997

Merged
merged 5 commits into from
Aug 20, 2022

Conversation

tbeswick96
Copy link
Contributor

@tbeswick96 tbeswick96 commented Aug 10, 2022

When merged this pull request will:

  • Add a setting to disable automatically carrying/dragging cargo on unload

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@PabstMirror PabstMirror added this to the 3.15.1 milestone Aug 12, 2022
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Aug 12, 2022
@LupusTheCanine
Copy link
Contributor

LupusTheCanine commented Aug 12, 2022

Would it be possible to add an ability to prohibit object from being picked up on per class basis? Large objects that can be dragged often collide with the carrier vehicle.

Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
@jonpas jonpas removed the request for review from oegitmen-avena August 15, 2022 17:47
@PabstMirror PabstMirror merged commit 2a4355d into acemod:master Aug 20, 2022
@markooff
Copy link
Contributor

markooff commented Aug 25, 2022

Thx :) - @tbeswick96 and @PabstMirror for taking care of this issue and, actually, big problem !

BUT

there is one thing more . In my opinion (and also opinions of users of my mod PGMLS ) there will be much better - to INTRODUCE a new special - PER CLASS SWITCH / Prohibitor - which can be used for a single class - to prevent this class (but ONLY this class/es) for being picked up automatically .

WHY IS IT SUCH IMPORTANT ?

Because your NEW solution (picking solution) still works perfectly - for some certain sorts of classes - like small boxes, crates and such objects . Let me just illustrate it:

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_16-49-50-24.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_16-50-00-75.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_16-50-29-42.jpg

...And it works for such objects (almost) perfectly !

BUT

for another types / classes of objects (which still could be dragged !) like quads, pontons, canoes, cargo palettes (and so on) - there is one big catastrophy :) with using them , after your last update (picking update)

Examples :

BEFORE :

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/2120189955_preview_Arma3_x64_2022-01-28_03-20-53-38.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/2120189955_preview_Arma3_x64_2022-01-28_03-23-28-62.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/2120189955_preview_Arma3_x64_2022-01-28_03-23-34-24.jpg

AFTER :

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_17-36-08-73.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_17-36-12-49.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_17-36-41-22.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_17-37-36-04.jpg

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/Arma3_x64_2022-08-25_17-37-48-67.jpg

The same is with other vehicles which act as a "cargo containers" for years , such like :

CH-53 and Quads (unloading) and so on ...

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/ch_53/Arma3_x64_2022-08-12_21-49-55-89.jpg

This situation in spite of the destruction of vehicle(s) will cause another annoying error - to leave out character freezed in DRAG animation ....

https://markooff.net/obrazki/PGM/bledy_army_ACE_itp/blad_cargo_unload_08_2022/ch_53/Arma3_x64_2022-08-12_21-50-02-11.jpg

SUMMARY:

I will vote AND ASK You for such solution like this described by Lupus the Canine in above post/comment, because in severall mods depended on ACE3 (mine including) we may want (and PEOPLE = users may want too )

  • and it's really worth to use this new "picking feature" for SOME classes , but there is no need to use it globally .....

THX for Your patience :)

@tbeswick96 tbeswick96 deleted the carry-after-unload-setting branch August 25, 2022 19:15
@tbeswick96
Copy link
Contributor Author

@LupusTheCanine @markooff As is the nature of open source, you're welcome to PR the ACE team with your suggestions, but I won't be doing this as part of this PR or at all :)

@markooff
Copy link
Contributor

markooff commented Aug 25, 2022

@tbeswick96 - Thanks for Your answer , I understand the rules nad benefits of the Open Source software , ( I cooperate with some linux software also )
but I still have a few other mods (my own) to carry about, because there are no other person who can do this ... :)
It's rather part of ACE3 and I think that making such a SWITCH will be much easier for those who work on ACE3 everyday than for me , where I hardly know the code of very few ACE3 modules (which I'm using - within my mods) .....
It's a problem of consistency of the whole mod also ... :)

To make myself clear - I don't ask You for doing per classes modifications (I know very well that even for Arma3 and a very limitted number of mods - there will be over than 600-800 classes to edit - because I already DID THIS more than once for my mods :) 🗡️ ) but I've only ask You for preparing one more condition in Your check (Your part in ACE3 mod ) - in unload_cargo mechanism - to check IF (for example) ace_cargo_pickingup_switch == 1 or == 0 and then to take an action , or just leave it without Your famous picking up feature .....

And the default value SHOULD be 1 - for compatibility reasons . :)

RusComBear pushed a commit to RusComBear/ACE3 that referenced this pull request Dec 29, 2023
* Add setting for carry after cargo unload

* Fix typos

* Contributors

* Don't make setting global

* Update addons/cargo/stringtable.xml

Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>

Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants